Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Agda 2.6.1 release candidate 1 #4212

Closed
jespercockx opened this issue Nov 19, 2019 · 64 comments
Closed

Release Agda 2.6.1 release candidate 1 #4212

jespercockx opened this issue Nov 19, 2019 · 64 comments
Assignees
@asr
Labels
type: task Concerning the development of Agda (not in changelog)
Milestone
2.6.1

Comments

@jespercockx
Copy link
Member

jespercockx commented Nov 19, 2019 •
edited
Loading

The time for the next release is coming close. We will not make our (optimistic) 1 December deadline, but it would be nice if we could release 2.6.1 before Christmas (or at least have a RC).

To avoid the delays and crunch period we had with the release of 2.6.0, I want to propose a policy to decide which issues must be fixed and which ones can be bumped. Let's define a critical issue as one in the following categories:

All other issues I consider non-critical.

I would like to ask everyone who has at least one open issue with the 2.6.1 milestone (@UlfNorell @andreasabel @asr @gallais @Saizan @ice1000 @xekoukou @L-TChen @hborum @mortberg @fredrikNordvallForsberg @Blaisorblade) to go over the list of 2.6.1 issues (https://github.com/agda/agda/issues?q=is%3Aopen+is%3Aissue+milestone%3A2.6.1) assigned to you and do the following:

  • If it is a critical issue (as defined above): decide whether you realistically will be able to work on it before Christmas, or else post a comment asking for help (and possibly also unassign yourself).
  • If it is a non-critical issue: choose one of the options above, or if you plan to work on it but not before the release, change the milestone to 2.6.2.

If you have the time, it would also be greatly appreciated if you could do a pass over the unassigned issues with 2.6.1 milestone (https://github.com/agda/agda/issues?q=is%3Aopen+is%3Aissue+milestone%3A2.6.1+no%3Aassignee) to decide if there are any you want to see fixed, and either assign yourself or post a comment asking if someone else can take it.

To avoid delays, please try to do these things before December the 1st. After that, I will start mercilessly bumping non-critical issues with no owner to 2.6.2.

Also please let me know if there are other categories of critical issues that I have missed, or if you have other comments about this proposed policy.
@jespercockx jespercockx added type: task Concerning the development of Agda (not in changelog) not-in-changelog This issue should not be listed in the changelog. labels Nov 19, 2019
@guillaumebrunerie
Copy link
Member

Hi Jesper, please take a look at my latest comment at #4122 (comment) (maybe I should have opened a new issue for it). It makes using Prop much harder than it was before (and is a regression on master).
Thanks!

@Blaisorblade
Copy link
Contributor

Hi Jesper, see my summary on this issue: #2009 (comment).

@ice1000
Copy link
Member

ice1000 commented Nov 19, 2019

I'll be closing the only issue (#4183) assigned me via #4213, which is a finished and waiting-for-CI PR.

@asr
Copy link
Member

asr commented Nov 20, 2019

We should add to the list of critical issues the support of new versions in the tool-chain (GHC, cabal-install, stack, alex, happy, etc). I filed #4216.

@asr asr self-assigned this Nov 20, 2019
@jespercockx
Copy link
Member Author

We should add to the list of critical issues the support of new versions in the tool-chain (GHC, cabal-install, stack, alex, happy, etc). I filed #4216.

Should we have a label for classifying these issues perhaps? That would make it easier to tell which issues should definitely not be bumped.

@nad
Copy link
Contributor

nad commented Nov 20, 2019 

* Bugs in unreleased features (labels `type: bug` and `not-in-changelog`): (no current issues)

I added the label not-in-changelog to some open issues related to @0 (#3855, #4137, #4169, #4172, #4174, #4195, and #4200).

@jespercockx
Copy link
Member Author 

* Bugs in unreleased features (labels `type: bug` and `not-in-changelog`): (no current issues)

I added the label not-in-changelog to some open issues related to @0 (#3855, #4137, #4169, #4172, #4174, #4195, and #4200).

Ok, I've added them to the OP.

@nad
Copy link
Contributor

nad commented Nov 20, 2019

Why not #3855? Oh, because it is an enhancement. Well, I think it makes sense to document @0 before releasing it. (I guess that technically it was released with Agda 2.6.0, but it did not work, and it was not mentioned in the changelog.)

I removed the not-in-changelog label from this issue, because I guess it makes sense to include it in the changelog.

@ice1000 ice1000 added this to the 2.6.1 milestone Nov 20, 2019
@nad
Copy link
Contributor

nad commented Dec 1, 2019

A new regression: #4253.

(Instead of manually listing things to fix in this ticket, wouldn't it be better to change the milestones of the things that we do not plan to fix before the release?)

@jespercockx
Copy link
Member Author

(Instead of manually listing things to fix in this ticket, wouldn't it be better to change the milestones of the things that we do not plan to fix before the release?)

I am planning to do this very soon, but as noted in the original post I wanted to give people the chance to pick up issues they want to see fixed before changing all milestones. Maybe it would make more sense to change all the milestones first and then change it back if necessary (something to think about for next release).

@nad
Copy link
Contributor

nad commented Dec 1, 2019

Another new regression: #4254.

@jespercockx
Copy link
Member Author

Thank you to everyone for your hard work so far. I bumped all the remaining unassigned non-critical issues to 2.6.2 (except for a few that I assigned to myself). This leaves us with 40 remaining open issues, of which:

Let's continue the hard work so we can get our Christmas release of Agda!

@L-TChen
Copy link
Member

L-TChen commented Dec 4, 2019

The issue #4072 is blocked by the license issue, and I don’t really know how to progress it further. Otherwise everything else is ready. It would be nice if @nad could kindly give me a hand.

I hope it can make contributing to Agda or the standard library more accessible to more people.

@nad
Copy link
Contributor

nad commented Dec 4, 2019

That code has presumably been released under the same licence as Agda. (At least that was my intention, I have not asked other contributors.) However, I am still sceptical towards moving fix-agda-whitespace to a separate repository, as documented in the ticket.

@L-TChen
Copy link
Member

L-TChen commented Dec 4, 2019

Okay, thanks. Now I put it into the ice box, so I don’t have any open issue assigned to me for now.

@asr
Copy link
Member

asr commented Dec 13, 2019 •
edited
Loading

I need to catch up with all the recent changes to the CI as preparation for the release. I'll create the release-2.6.1 branch from the current master and make the necessary changes to the CI (e.g. test with all the supported GHC versions) for releasing.

@asr
Copy link
Member

asr commented Dec 14, 2019

Travis is reporting the following error in the release-2.6.1 branch:

/home/travis/.travis/functions: line 109: eval: - : invalid option
eval: usage: eval [arg ...]

Any idea what is wrong?

@L-TChen
Copy link
Member

L-TChen commented Dec 14, 2019 •
edited
Loading

My bad. Please remove the bar | on

agda/.travis.yml

Line 190 in 29790fa

script: |

@asr
Copy link
Member

asr commented Dec 14, 2019 •
edited
Loading

Done. Thanks!

@asr
Copy link
Member

asr commented Dec 14, 2019 •
edited
Loading

@L-TChen, there are more errors related to the .travis.yml file reported by Travis on the release-2.6.1 branch. Since we don't merge the release branches into master, you should fix the errors in master and merge master into release-2.6.1.

asr added a commit that referenced this issue Dec 14, 2019
@asr
[ #4212, CHANGELOG ] Added list of current closed issues.
74cc524 
[ci skip]
asr added a commit that referenced this issue Dec 14, 2019
@asr
[ #4212, CHANGELOG ] Fixed links of closed issues.
f1b00aa 
[ci skip]
@asr
Copy link
Member

asr commented Dec 14, 2019

I added the list of current closed issues to the CHANGELOG. Tell me if you find a missing or wrong listed issue.

@ice1000
Copy link
Member

ice1000 commented Dec 14, 2019

The CHANGELOG.md is way too big. I think it's good to split it (version-per-file or some-versions-per-file or something)

@ice1000
Copy link
Member

ice1000 commented Dec 14, 2019

@asr do you have a script for generating the "closed issues" section?

@asr asr mentioned this issue Dec 14, 2019
Closed
@L-TChen
Copy link
Member

L-TChen commented Dec 18, 2019 •
edited
Loading

The trigger list has been updated by 00180cd. @asr, I also include your proposed change, i.e. checking out submodules, to the commit.

asr added a commit that referenced this issue Dec 19, 2019
@asr
[ #4212 ] Changed version to 2.6.0.1.20191218.
5755b34
@JacquesCarette
Copy link
Contributor

I am trying to get a version of 2.6.1 compiling locally, so that I can test agda-categories with it, to ensure no additional regressions sneak in. But I'm having a difficult time with getting it 'ready', mostly because it seems that the HACKING.md instructions are not fully in-synch with 2.6,1.

Just to get started: should I be using the cabal v1 route, or the stack route? Does it matter? [I've experimented, things go weird, but I'd rather use the recommended one, and then report problems with it.]

@asr
Copy link
Member

asr commented Dec 19, 2019

Just to get started: should I be using the cabal v1 route, or the stack route? Does it matter?

It does not matter. Both routes are working.

@L-TChen
Copy link
Member

L-TChen commented Dec 19, 2019

@JacquesCarette, stack and cabal v1 or even v2 (with GHC 8.8.1) all are tested and should be working. If you’d like to, can you report the problem you have in another ticket?

@JacquesCarette
Copy link
Contributor

Ok. I'll work on it systematically, in the hopes of being able to file reproducible bugs (in separate tickets). I'll have time this afternoon and tomorrow.

@asr
Copy link
Member

asr commented Dec 19, 2019

@JacquesCarette, thanks for thinking on test agda-categories with the upcoming 2.6.1. In fact, I found a problem but I'll wait for you report it using a minimal example if possible.

@asr
Copy link
Member

asr commented Dec 19, 2019 •
edited
Loading

I'll be without Internet access from 25th of December to January 1st. I think the release-2.6.1 branch is in a good shape for preparing and releasing a release candidate today (mentioning the current open issues) or we can wait until the first weeks of January for releasing the release candidate hoping without knowing regressions. What do you think?

I suggest to release the release candidate today. In this way, we could release a second release candidate or the final version in the first weeks of January.

@jespercockx
Copy link
Member Author

I'm in favour of bringing out a release candidate today! It will make for a nice Christmas present.

@JacquesCarette
Copy link
Contributor

I've found at least 2 regressions - will post some reports as soon as I've managed to make reasonably minimal examples.

asr added a commit that referenced this issue Dec 20, 2019
@asr
[ #4212, CHANGELOG ] Updated list of closed issues.
40034c5 
[ci skip]
@asr
Copy link
Member

asr commented Dec 20, 2019

I'm starting the preparation of the release candidate from the current master (40034c5), so the release-2.6.1 branch is frozen.

@asr
Copy link
Member

asr commented Dec 20, 2019

I couldn't prepare the release candidate for 2.6.1 using cabal-install 3.0.0.0 due to haskell/cabal#5813.

@JacquesCarette JacquesCarette mentioned this issue Dec 20, 2019
Open
@JacquesCarette
Copy link
Contributor

@L-TChen I can definitely report that I was able to get going, with a minimum of fuss, with stack. The overall instructions could be improved [which I hope to attempt to do myself], but it worked.

The good news is that I was able to apply a workaround to both regressions, so that agda-categories currently works with both 2.6.0.1 and 2.6.1 (and stdlib-1.2).

asr added a commit that referenced this issue Dec 20, 2019
@asr
[ #4212 ] Changes to Agda.cabal.
87a3b45 
* Removed `-Werror`.

* Removed `-fprof-auto`.

* Removed Cabal test-suite.

* Added `doc/user-manual.pdf`.
asr added a commit that referenced this issue Dec 20, 2019
@asr
Revert "[ #4212 ] Changes to Agda.cabal."
edb9e98 
This reverts commit 87a3b45.
@asr
Copy link
Member

asr commented Dec 20, 2019 •
edited
Loading

I uploaded to Hackage the release candidate Agda-2.6.0.1.20191219 and I tested its installation on Ubuntu with

GHC cabal-install
8.8.1 3.0.0.0
8.6.5 2.4.1.0
8.4.4 2.2.0.0
8.2.2 2.0.0.1
8.0.2 1.24.0.2

Could someone test the installation on macOS and Windows using the following instructions:

$ cabal get https://hackage.haskell.org/package/Agda-2.6.0.1.20191219/candidate/Agda-2.6.0.1.20191219.tar.gz
$ cd Agda-2.6.0.1.20191219
$ cabal install

@ggreif
Copy link
Contributor

ggreif commented Dec 21, 2019 via email •
edited
Loading

@asr
Copy link
Member

asr commented Dec 21, 2019

The middle command should be

cd Agda-2.6.0.1.20191219

Oops! Fixed. Thanks!

@asr
Copy link
Member

asr commented Dec 21, 2019 •
edited
Loading

Installing gave me

$ cabal install
cabal: Unknown target '.'.
There is no component '.'.
The project has no package directory '.'.

Not sure what this is.
I am on MacOS X High Sierra,

[nix-shell:~/agda/Agda-2.6.0.1.20191219]$

I could reproduce the error by installing Agda-2.6.0.1.20191219 inside the directory where I have the upstream version. I guess the error is due to the cabal.project file in this directory.

Please move Agda-2.6.0.1.20191219 outside the ~/agda directory and try again.

@ggreif
Copy link
Contributor

ggreif commented Dec 21, 2019

Please move Agda-2.6.0.1.20191219 outside the ~/agda directory and try again.

Yep, that seems to work:

[nix-shell:~/Agda-2.6.0.1.20191219]$ cabal v2-install agda agda-mode --installdir=/Users/ggreif/.cabal/bin -j6
Wrote tarball sdist to
/Users/ggreif/Agda-2.6.0.1.20191219/dist-newstyle/sdist/Agda-2.6.0.1.20191219.tar.gz
Resolving dependencies...
Build profile: -w ghc-8.6.5 -O1
In order, the following will be built (use -v for more details):
 - Agda-2.6.0.1.20191219 (exe:agda, exe:agda-mode) (requires build)
Starting     Agda-2.6.0.1.20191219 (all, legacy fallback)
Building     Agda-2.6.0.1.20191219 (all, legacy fallback)
Installing   Agda-2.6.0.1.20191219 (all, legacy fallback)
Completed    Agda-2.6.0.1.20191219 (all, legacy fallback)
Symlinking 'agda'
cabal: Path '/Users/ggreif/.cabal/bin/agda' already exists. Use
--overwrite-policy=always to overwrite.


[nix-shell:~/Agda-2.6.0.1.20191219]$ cabal v2-install agda agda-mode --installdir=/Users/ggreif/.cabal/bin -j6 --overwrite-policy=always
Wrote tarball sdist to
/Users/ggreif/Agda-2.6.0.1.20191219/dist-newstyle/sdist/Agda-2.6.0.1.20191219.tar.gz
Resolving dependencies...
Up to date
Symlinking 'agda'
Symlinking 'agda-mode'

@asr
Copy link
Member

asr commented Dec 21, 2019

Thanks for testing. In your case I guess something like

$ cabal install -j6

should be enough.

@asr
Copy link
Member

asr commented Dec 21, 2019

Could someone test the release candidate on Windows?

@asr
Copy link
Member

asr commented Dec 22, 2019 •
edited
Loading

I did not study the list carefully, but I noticed that #3856 is included. This is not a bug fix, and it is documented elsewhere in the changelog. Should issues like this be included? I suggest that we only include bug fixes for released features.

I'll added the label documented-in-changelog for issues which are already documented in the CHANGELOG. These issues will not include in the list of closed issues.

@asr
Copy link
Member

asr commented Dec 22, 2019

I updated the list of other closed issues in the CHANGELOG. If you closed an issue which wasn't a bug but an enhancement, please added one entry to the CHANGELOG. In this way, we can change the title 'Other closed issues' to 'Other fixed bugs'.

@asr asr changed the title Release Agda 2.6.1 Release Agda 2.6.1 release candidate 1 Dec 22, 2019
@asr
Copy link
Member

asr commented Dec 22, 2019

Done. Released the release candidate.

@asr asr closed this as completed Dec 22, 2019
@jespercockx jespercockx mentioned this issue Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asr asr

Labels
type: task Concerning the development of Agda (not in changelog)
Projects
None yet
Milestone
2.6.1
Development

No branches or pull requests
9 participants
@Blaisorblade @nad @asr @guillaumebrunerie @ggreif @JacquesCarette @jespercockx @L-TChen @ice1000