Use haskell-src-exts instead of generating strings #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes putting LANGUAGE pragmas before the module header
UlfNorell
force-pushed
the
hs-src-exts
branch
from
96fcb00 to
0c63489
Compare
and tidy up a little
jmchapman
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
On first glance this is great.
A couple of questions:
- If you wanted to further beautify the haskell source would you then run it through something else?
haskell-src-extshas this ominous message on hackage:
Maintenance
Dan Burton is currently keeping haskell-src-exts on life support. If you are interested in more actively making improvements to this package, please make your interests known.
You might want to try ghc-lib-parser instead.
Is ghc-lib-parser similar or is the current version of haskell-src-exts exactly what we want?
|
Ooh, that's slightly worrying. Merging anyway since it should be a lot easier to switch from I haven't looked at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes putting LANGUAGE pragmas before the module header.
The code still isn't very nice but at least now we don't have to worry about precedences.
Generates some conflicts for #3.