Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflection API changing in Agda 2.6.3 #743

Closed
andreasabel opened this issue Mar 26, 2022 · 6 comments
Closed

Reflection API changing in Agda 2.6.3 #743

andreasabel opened this issue Mar 26, 2022 · 6 comments

Comments

@andreasabel
Copy link
Member

andreasabel commented Mar 26, 2022

The current master of cubical does not build with Agda master, breaking here:

extend*Context (a ∷ as) tac = R.extendContext a (extend*Context as tac)

extendContext expects one more argument now:

extendContext    :  {a} {A : Set a}  String  Arg Type  TC A  TC A

Agda's reflection API changed in agda/agda#5715 (unreleased, scheduled for Agda 2.6.3).

Maybe you should maintain a branch that builds with latest Agda master. This branch could be merged into master once you bump to a new release of Agda (from master). Currently we (Agda devs) cannot really test (from the Agda side) whether cubical and Agda are still in sync. If such a branch existed, we could pin our cubical submodule to this branch and run Agda on it from our testsuite/CI.

@andreasabel
Copy link
Member Author

@mortberg
Copy link
Collaborator

Ah, yes indeed the current version of the library is supposed to build on the latest release of Agda to not force us to update our Agda installations all the time when working on the library. Having a branch that builds on Agda master would indeed be ideal. How about calling it Agda-master or something?

@MatthewDaggitt
Copy link

If you wanted to be consistent with the standard library, we call it experimental (see our docs)

@andreasabel
Copy link
Member Author

@mortberg @MatthewDaggitt

If you wanted to be consistent with the standard library, we call it experimental (see our docs)

Maybe standard-library could rename it to Agda-master instead?
experimental is ambiguous, and quite frankly, I am often confused. It could refer to experimental features either in Agda or the standard-library...
Agda-master is a clearly purposed name.
(Too bad git doesn't (allow to) attach comments to branches.)

L-TChen added a commit to L-TChen/cubical that referenced this issue Mar 27, 2022
@L-TChen
Copy link
Member

L-TChen commented Mar 27, 2022

Having a branch that builds with the latest development version of Agda is ideal, but for this issue, it also makes sense to remove extend*Context (#745).

L-TChen added a commit that referenced this issue Mar 28, 2022
`extend*Context` is the only function incompatible with the development version 2.6.3 of Agda. It is not used elsewhere in the library.

Removing it makes the library compatible with Agda 2.6.3 again.
@felixwellen
Copy link
Collaborator

This is outdated by now, cubical typechecks with agda 2.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants