-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mentions of the Id type #1005
Conversation
Is there somewhere I can read about this change? I just started using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this seems reasonable. What does @ecavallo think ? If you're happy feel free to merge
OK by me |
Did you notice the conflicts? |
Something that was done here, but not in #1011 is deletion of things like |
Oops, I missed that.. Can @plt-amy update the PR to fix the conflicts and then we can merge? |
Sure, I'll have a look later today 🙂 |
0b61776
to
86bc007
Compare
86bc007
to
3adc4cd
Compare
Looks good to me! Is this ready to be merged? |
Looks good (and ready) to me |
With the addition of indexed inductive types to Cubical Agda, having the built-in cubical identity type is redundant, since it has exactly the same computational behaviour as the indexed equality. However, cubical identity has its own support code for pattern matching, the Kan operations, and its magic type checking rule, which is now for no benefit. This PR removes the mentions of it from the library so I can remove it from Agda.