Lindenbaum-Tarski algebra #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
Apart from a small comment I think this looks good.
One could maybe split this into multiple files and move some stuff to other parts, like the definition of propositional formulas and the proof system... On the other hand, the logical system is somewhat tailored for the construction of the LT algebra. What does @ecavallo and @felixwellen think?
|
I think it's fine like it is now (agreeing that a comment explaining the file contents would be great). We can think about splitting off the logic-parts in our future refactoring that finally puts the logic related things in the library at a place where they are not completely unexpected ;-) |
mortberg
reviewed
Jun 20, 2023
mortberg
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lindenbaum-Tarski algebra of propostional logic.