Zariski coverage on CommRing^op #1082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(with Max Zeuner)
…ical into ZariskiSite
mzeuner
commented
Dec 1, 2023
| module AU = A.UniversalProp | ||
| module BU = B.UniversalProp | ||
|
|
||
| ψ : (i : Fin (um .n)) → CommRingHom A.R[1/ um .f i ]AsCommRing B.R[1/ φ $r um .f i ]AsCommRing |
There was a problem hiding this comment.
Unfortunately, --lossy-unification is needed to both show that ψ has the above type and fills the goal where it's used. I tried to play around with opaque, but to no avail.
Any ideas anyone?
There was a problem hiding this comment.
I think the solution should be to make the operation R[1/_]AsCommRing opaque. But I don't have the energy to actually carry that out, it is used in too many places.
MatthiasHu
reviewed
Jan 16, 2024
MatthiasHu
reviewed
Jan 16, 2024
Merged
MatthiasHu
approved these changes
Feb 6, 2024
| module AU = A.UniversalProp | ||
| module BU = B.UniversalProp | ||
|
|
||
| ψ : (i : Fin (um .n)) → CommRingHom A.R[1/ um .f i ]AsCommRing B.R[1/ φ $r um .f i ]AsCommRing |
There was a problem hiding this comment.
I think the solution should be to make the operation R[1/_]AsCommRing opaque. But I don't have the energy to actually carry that out, it is used in too many places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing the draft PR (#1081) with @MatthiasHu.