Kernel ideals and universal property of ring quotients #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also: generalize to non commutative scalars
# Conflicts: # Cubical/Structures/CommRing.agda # Cubical/Structures/Ring.agda
# Conflicts: # Cubical/Structures/AbGroup.agda # Cubical/Structures/Group.agda # Cubical/Structures/Ring.agda
* variables are indexed by an arbitrary type * show it is a commutative algebra
# Conflicts: # Cubical/Structures/AbGroup.agda # Cubical/Structures/Group.agda
# Conflicts: # Cubical/Structures/Ring.agda
# Conflicts: # Cubical/Algebra/Monoid/Base.agda # Cubical/Algebra/QuotientRing.agda # Cubical/Algebra/Ring/Base.agda
|
No, actually it is also confusing because I messed it up... |
|
Now the changes match what I wrote. |
mortberg
requested changes
Oct 2, 2020
I'll try to figure out what happened. I missed it when looking at the changes because it was collapsed. |
mortberg
approved these changes
Oct 2, 2020
|
Perfect! Will merge once Travis is finished. @mzeuner : I guess Localization should go in the Algebra.Ring subfolder once I've merged this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RingHoms, kernels of RingHoms as ideals and the universal property of ring quotients.
The history might be confusing, since algebra code was restructered in between.
The only real updates from this PR are Kernel.agda, some extension of QuotientRing.agda, a new record 'RingHom' in Ring.Base and some minor changes in Ring.Properties.