Clean up RingSolver and extract NatSolver #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cubical/Algebra/CommRing/FGIdeal.agda
ecavallo
requested changes
Dec 16, 2021
ecavallo
requested changes
Dec 16, 2021
|
Thanks! |
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a long overdue clean up of the RingSolver code.
It removes everything from Cubical/Algebra/RingSolver, that is not needed in the latest version of the ring solver. Additionally, an old prototype of the solver, that also worked for semirings is salvaged in the form of the NatSolver - a solver which is specialized to the natural numbers. The idea is, that this will probably be useful and pretty easy to apply. A simple reflection interface is included.
There is some duplication left between RingSolver and NatSolver (at least some functions in the reflection interfaces), but I think it would be not worth the effort to deduplicate.