Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardinality and Quotients of Finite Sets #630

Merged
merged 21 commits into from
Mar 15, 2022
Merged

Conversation

kangxyz
Copy link
Contributor

@kangxyz kangxyz commented Nov 19, 2021

This PR is a following-up of #620 and it contains:

  • Many properties of cardinality, e.g., facts about cardinality, some basic counting formula and a general version of pigeonhole principle;
  • A universe polymorphic version of Fin and based on that an inductive eliminator of FinSet towards propositions, making certain proof cleaner;
  • Facts about quotients. In particular a proof that quotient of finite set by decidable equivalence relation is still finite set;
  • Modifications in library.

See Cubical.Experiments.Combinatorics that things actually work and compute.

@kangxyz kangxyz changed the title Cardinality of Finite Sets Cardinality and Quotients of Finite Sets Nov 21, 2021
Copy link
Collaborator

@ecavallo ecavallo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I just have some clean-up requests before I merge.

Cubical/Data/Fin/Properties.agda Outdated Show resolved Hide resolved
Cubical/Data/Fin/Properties.agda Outdated Show resolved Hide resolved
Cubical/Data/FinSet/Induction.agda Outdated Show resolved Hide resolved
Cubical/Data/FinSet/Properties.agda Outdated Show resolved Hide resolved
Cubical/Data/FinSet/Cardinality.agda Outdated Show resolved Hide resolved
Cubical/Data/FinSet/Induction.agda Outdated Show resolved Hide resolved
Cubical/Data/FinSet/Quotients.agda Outdated Show resolved Hide resolved
Cubical/Data/Nat/Order.agda Outdated Show resolved Hide resolved
Cubical/Data/Nat/Order.agda Outdated Show resolved Hide resolved
Cubical/Data/SumFin/Properties.agda Outdated Show resolved Hide resolved
@kangxyz kangxyz requested a review from ecavallo March 15, 2022 05:12
@kangxyz
Copy link
Contributor Author

kangxyz commented Mar 15, 2022

@ecavallo Thanks for reviewing! Everything is done now.

@ecavallo ecavallo merged commit 86d971f into agda:master Mar 15, 2022
@ecavallo
Copy link
Collaborator

Thanks!

@kangxyz kangxyz deleted the combinatorics branch March 26, 2022 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants