Free Commutative Monoid #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortberg
approved these changes
Mar 10, 2022
mortberg
reviewed
Mar 10, 2022
| AssocList≃FCMon : FreeComMonoid A ≃ AssocList A | ||
| AssocList≃FCMon = isoToEquiv (iso FCM→AL AL→FCM FCM→AL∘AL→FCM≡id AL→FCM∘FCM→AL≡id) | ||
|
|
||
| FCMon≡AssocList : AssocList A ≡ FreeComMonoid A |
There was a problem hiding this comment.
Wait, this name is a bit weird... It should be AssocList≡FreeComMonoid. Similarly for the two definitions above.
There was a problem hiding this comment.
I have already changed the name.
There was a problem hiding this comment.
Great, can you also fix the name of FCMon≃AssocList? And remove AssocList≃FCMon? I think it's unnecessary to have both when we can just use invEquiv to turn one of them around
There was a problem hiding this comment.
I have already made these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Free Commutative Monoid in the library.
To prove that it is isomorphic to the associative list, I had to add some auxiliary functions there.