-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
swap the argument order in equational reasoning #999
swap the argument order in equational reasoning #999
Conversation
I think the problematic code can be removed safely, since it wasn't in use anyway. I'm just type checking that and will make a PR on your PR once it is through. |
Here it is, just in case it doesn't show up automatically (not checked yet, but I guess it is good to merge into this PR): |
Type checks on my machine and I actually could just substitute the worst ringsolver-macro with another one, because the RHS is available now in equational reasoning. |
As far as I can tell, that should be ready for merging - or do you want to change anything? |
Looks good to me. Main thing I would want to add is a test that demonstrate it works with equational reasoning |
Have you looked at the CommRingSolver/Examples? |
Oh I guess I missed those. LGTM then |
Okay -> merging. |
Addressing #998 .
Currently not building because the current solvers have some hacks in them related to equational reasoning that I haven't fixed because they might not be necessary after this change. It would be nice to have an example of how this helps with a solver. I have a category solver in a different repo that I'm currently using to verify that this helps.
In the stdlib they also changed other *-reasoning syntax. I'm not familiar enough with the stdlib to know where all of those would be. Additionally I haven't change
≡⟨⟩⟨⟩-syntax
or_≡⟨_⟩≡⟨_⟩_
yet but they should be similarly adapted as well.