Bug fix/mpsk not member #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #773 +/- ##
===========================================
+ Coverage 87.88% 87.90% +0.01%
===========================================
Files 275 277 +2
Lines 16949 16993 +44
===========================================
+ Hits 14895 14937 +42
- Misses 2054 2056 +2 ☔ View full report in Codecov by Sentry. |
agmes4
force-pushed
the
bug-fix/mpsk_not_member
branch
from
5c7d453 to
617b6c8
Compare
|
Please do not check for the So better check for the |
|
I see the point but think that this api should just be usable when you are a member. So in case of legacy accounts its still possible to set them when they have wifi access. |
|
never mind looked it up they can login into sipa that was |
checks that a user can add mpsk client has the property network access otherwise it retruns a 412
added the test for not members mpsk now its validated rather a user is a member and can add or change mpsk clients
agmes4
force-pushed
the
bug-fix/mpsk_not_member
branch
from
617b6c8 to
c7e8408
Compare
lukasjuhrich
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Fixes that now users can not add or create mpsk clients
fixed #772