Skip to content

Use proper decode from json function on WebSocketTransport #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nerzhulart merged 1 commit into from
Nov 24, 2025
Merged

Use proper decode from json function on WebSocketTransport #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion acp-ktor/src/commonMain/kotlin/com/agentclientprotocol/transport/WebSocketTransport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package com.agentclientprotocol.transport

import com.agentclientprotocol.rpc.ACPJson
import com.agentclientprotocol.rpc.decodeJsonRpcMessage
import com.agentclientprotocol.rpc.JsonRpcMessage
import io.github.oshai.kotlinlogging.KotlinLogging
import io.ktor.websocket.*
Expand Down Expand Up @@ -59,7 +60,7 @@ public class WebSocketTransport(private val parentScope: CoroutineScope, private
is Frame.Text -> {
val text = message.readText()
val decodedMessage = try {
ACPJson.decodeFromString<JsonRpcMessage>(text)
decodeJsonRpcMessage(text)
} catch (e: SerializationException) {
logger.trace(e) { "Failed to deserialize message: '$text'" }
fireError(e)
Expand Down
Loading