Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added output parsing to reAct agent #64

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

Tsomoriri
Copy link
Collaborator

@Tsomoriri Tsomoriri commented Apr 4, 2024

🤔 Reasoning

Trying out structured output parsing in reAct agent

🚧 Changes

  • Added ReActOutput class which specifies the agent generate() output format
  • Changed test_react to accommodate new style of output

✅ PR Checklist

  • Using this PR template?
  • Linked issue?
  • Added feature?
    • Added/updated docs?
    • Added/updated tests?

@Tsomoriri Tsomoriri requested a review from alckasoc April 4, 2024 21:05
Copy link
Member

@alckasoc alckasoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, double check linting + quick question:

how sensitive are the output descriptions within ReactOutput? Have you tested this and verified the formatting is correct? How's the output format affected by the output descriptions?

@Tsomoriri
Copy link
Collaborator Author

the linting is failing at the zeroshotreact agent which is an import from langchain. I can try to debug it if its important

Tested the output formatting w.r.t the unit test framework. The formatting is exact match as the input formatting was before.
The descriptions in real world testing is pending due to an issue with my openapi key. But,I doubt that it would raise an issue as I have worked with different agents which do use structured outputs and they work perfectly.

@Tsomoriri Tsomoriri self-assigned this Apr 7, 2024
@alckasoc alckasoc merged commit ce904df into main Apr 8, 2024
6 checks passed
@alckasoc alckasoc deleted the sushen/reAct_with_output_parsing branch April 8, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants