Skip to content

Comments

Code Review Bench PR #30156 - fix: remove hardcoded 48-character limit from text inputs#5

Open
tomerqodo wants to merge 2 commits intobase_pr_30156_20260125_2820from
corrupted_pr_30156_20260125_2820
Open

Code Review Bench PR #30156 - fix: remove hardcoded 48-character limit from text inputs#5
tomerqodo wants to merge 2 commits intobase_pr_30156_20260125_2820from
corrupted_pr_30156_20260125_2820

Conversation

@tomerqodo
Copy link

Code Review Bench PR langgenius#30156

Original PR Title: fix: remove hardcoded 48-character limit from text inputs
Original PR Description: ## Summary

  • Removes the hardcoded DEFAULT_VALUE_MAX_LEN (48 characters) fallback from text input components
  • When max_length is not configured, inputs now have no character limit as expected
  • Only applies maxLength when explicitly configured by the user

Test plan

  • All existing tests pass (5458 tests)
  • Added new tests to verify maxLength behavior:
    • Input should not have maxLength attribute when max_length is not set
    • Input should have maxLength attribute when max_length is set

fixes langgenius#26940
Original PR URL: langgenius#30156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant