Fix queue processing mode handling and stabilize tests #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor signal queue processing to properly handle step and debug modes: - Add synchronous handle_call(:process_queue, ...) for explicit queue processing in step/debug modes - Modify handle_info(:process_queue, ...) to only auto-process in auto mode, preventing unintended processing in step/debug modes - Extract maybe_trigger_queue_processing/1 helper that conditionally triggers async processing based on current mode Update test infrastructure for reliable cross-process synchronization: - Add wait_for_received_signals/3 helper to properly wait for signal delivery in async scenarios - Modify spawn_producer_agent and spawn_consumer_agent to default to auto mode for consistent behavior - Add maybe_process_queue/1 helper to explicitly trigger processing when testing in step mode - Replace Process.sleep with proper wait_for assertions in send_signal_sync - Improve error handling in agent cleanup to catch exit signals
Contributor
Author
|
There's still some test flakiness. Will submit another commit today. |
Contributor
|
thank you @nshkrdotcom Please take a look at the |
Contributor
Author
|
Perfect. I'll push what I have here, and focus on the latest work. |
Centralize agent cleanup logic in Support.cleanup_agent/1 and make it safer by unlinking before stopping to prevent linked-exit propagation from killing the cleanup process. Changes: - Add Process.unlink/1 call before GenServer.stop in cleanup_agent - Add guard clause (when is_pid) for type safety - Delegate stop_test_agent in AgentCase to shared cleanup function - Use Support.unique_id for invalid refs in interaction tests to avoid async test collisions between concurrent test runs - Split atom reference test separately since fixed atoms are safe
Contributor
Author
|
These changes ended up being inapplicable to the v2 cleanup. Not sure if you're doing maintenance work on this older version. |
Contributor
|
Yeah, we will be maintaining 1.0 The 2.0 branch is very alpha at the moment - but getting there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing