Skip to content

feat(req): Allows setting up Req Plugins on High-level api#360

Draft
ycastorium wants to merge 3 commits intoagentjido:mainfrom
grain-team:allow_req_plugins
Draft

feat(req): Allows setting up Req Plugins on High-level api#360
ycastorium wants to merge 3 commits intoagentjido:mainfrom
grain-team:allow_req_plugins

Conversation

@ycastorium
Copy link
Contributor

@ycastorium ycastorium commented Jan 26, 2026

Description

Allows setting up Req Plugins on High-level api

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update

Breaking Changes

Testing

  • Tests pass (mix test)
  • Quality checks pass (mix quality)

Checklist

  • My code follows the project's style guidelines
  • I have updated the documentation accordingly
  • I have added tests that prove my fix/feature works
  • All new and existing tests pass
  • My commits follow conventional commit format
  • I have NOT edited CHANGELOG.md (it is auto-generated by git_ops)

Related Issues

Closes #359

@mikehostetler
Copy link
Contributor

Thanks for the contribution! However, I'm going to hold off on merging this for now:

  1. Finch streaming not supported - The :req_plugins option only works for non-streaming operations. Streaming uses Finch directly via attach_stream/4, so plugins wouldn't apply there. This creates an inconsistent API surface.

  2. Moving away from Req - We're planning to move away from Req in the future, which would make this feature short-lived and potentially a breaking change down the road.

I appreciate the effort here, but given these concerns I don't think this is the right addition at this time.

@mikehostetler mikehostetler marked this pull request as draft January 30, 2026 23:14
@ycastorium
Copy link
Contributor Author

Thanks for the contribution! However, I'm going to hold off on merging this for now:

1. **Finch streaming not supported** - The `:req_plugins` option only works for non-streaming operations. Streaming uses Finch directly via `attach_stream/4`, so plugins wouldn't apply there. This creates an inconsistent API surface.

2. **Moving away from Req** - We're planning to move away from Req in the future, which would make this feature short-lived and potentially a breaking change down the road.

I appreciate the effort here, but given these concerns I don't think this is the right addition at this time.

Aha! Good to know, that you are planning that! Thanks for the input.

@mikehostetler mikehostetler added the needs_work Changes requested before merge label Feb 14, 2026
@mikehostetler
Copy link
Contributor

Thanks again for the original contribution. I'm adding needs_work to reflect current blocker status before this can land.

This PR is still draft and the current direction concerns from maintainers remain: streaming parity and long-term API direction around Req plugin exposure in high-level APIs.

If you want to continue this, please update scope/proposal to address those points and we can re-evaluate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs_work Changes requested before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Allow setting up Req Attachments without the need of using low level API

2 participants