-
Notifications
You must be signed in to change notification settings - Fork 55
Add TOPR and CISPO algorithm #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yanxi-chen
merged 18 commits into
agentscope-ai:main
from
garyzhang99:dev/add_new_algorithms
Sep 2, 2025
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
4b87ed4
add topr and cispo algorithm
garyzhang99 c51053a
register new algorithm and polish functions
garyzhang99 7f66302
fix typos and mistakes
garyzhang99 5db9d86
fix typo
garyzhang99 b9ec4bf
merge main
garyzhang99 375f90d
del add strategy, make it consistent with main
garyzhang99 bb577c3
merge main again
garyzhang99 3579e48
add examples for topr and cispo
garyzhang99 d2cfbe0
fix lr
garyzhang99 fedd1af
seperate mask clip for cispo
garyzhang99 990eacc
Merge branch 'main' into dev/add_new_algorithms
garyzhang99 5f2df78
merge main again
garyzhang99 87206be
Merge branch 'main' into dev/add_new_algorithms
garyzhang99 2c20092
fix precommit
garyzhang99 9340067
add missing file
garyzhang99 c07d914
fix pre-commit
garyzhang99 ac117db
update with main again
garyzhang99 9c52bf8
update with main again and gain
garyzhang99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # CISPO on GSM8K dataset | ||
|
|
||
| This example shows the usage of [CISPO](https://arxiv.org/abs/2506.13585) on the GSM8K dataset. | ||
|
|
||
| The config files are located in [`gsm8k.yaml`](gsm8k.yaml) and [`train_gsm8k.yaml`](train_gsm8k.yaml). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| project: "Trinity-RFT-gsm8k" | ||
| name: "qwen2.5-1.5B-gsm8k-cispo" | ||
| checkpoint_root_dir: /PATH/TO/CHECKPOINT/ | ||
| algorithm: | ||
| algorithm_type: cispo | ||
| repeat_times: 8 | ||
| model: | ||
| model_path: /PATH/TO/MODEL/ | ||
| max_response_tokens: 1024 | ||
| max_model_len: 1280 | ||
| cluster: | ||
| node_num: 1 | ||
| gpu_per_node: 8 | ||
| buffer: | ||
| total_epochs: 1 | ||
| batch_size: 96 | ||
| explorer_input: | ||
| taskset: | ||
| name: gsm8k | ||
| storage_type: file | ||
| path: 'openai/gsm8k' | ||
| subset_name: 'main' | ||
| split: 'train' | ||
| format: | ||
| prompt_key: 'question' | ||
| response_key: 'answer' | ||
| rollout_args: | ||
| temperature: 1.0 | ||
| eval_tasksets: | ||
| - name: gsm8k-eval | ||
| storage_type: file | ||
| path: 'openai/gsm8k' | ||
| subset_name: 'main' | ||
| split: 'test' | ||
| format: | ||
| prompt_key: 'question' | ||
| response_key: 'answer' | ||
| default_workflow_type: 'math_workflow' | ||
| trainer_input: | ||
| experience_buffer: | ||
| name: gsm8k_buffer | ||
| storage_type: queue | ||
| path: 'sqlite:///gsm8k.db' | ||
| # sft_warmup_steps: 0 | ||
| # sft_warmup_dataset: # Uncomment these to enable sft warmup | ||
| # name: warmup_data | ||
| # storage_type: file | ||
| # path: '/PATH/TO/WARMUP_DATA/' | ||
| explorer: | ||
| eval_interval: 50 | ||
| runner_num: 32 | ||
| rollout_model: | ||
| engine_type: vllm_async | ||
| engine_num: 2 | ||
| tensor_parallel_size: 1 | ||
| enable_prefix_caching: false | ||
| enforce_eager: true | ||
| dtype: bfloat16 | ||
| seed: 42 | ||
| synchronizer: | ||
| sync_method: 'nccl' | ||
| sync_interval: 4 | ||
| sync_timeout: 1200 | ||
| trainer: | ||
| trainer_type: 'verl' | ||
| trainer_config_path: 'examples/cispo_gsm8k/train_gsm8k.yaml' | ||
| save_interval: 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| actor_rollout_ref: | ||
| hybrid_engine: True | ||
| model: | ||
| external_lib: null | ||
| override_config: { } | ||
| enable_gradient_checkpointing: True | ||
| use_remove_padding: True # False | ||
| actor: | ||
| strategy: fsdp # This is for backward-compatibility | ||
| ppo_micro_batch_size_per_gpu: 4 | ||
| use_dynamic_bsz: True # False | ||
| ppo_max_token_len_per_gpu: 16384 | ||
| grad_clip: 1.0 | ||
| ppo_epochs: 1 | ||
| shuffle: False | ||
| ulysses_sequence_parallel_size: 1 # sp size | ||
| optim: | ||
| lr: 1e-5 | ||
| lr_warmup_steps_ratio: 0. # the total steps will be injected during runtime | ||
| # min_lr_ratio: null # only useful for warmup with cosine | ||
| warmup_style: constant # select from constant/cosine | ||
| total_training_steps: -1 # must be override by program | ||
| fsdp_config: | ||
| wrap_policy: | ||
| # transformer_layer_cls_to_wrap: None | ||
| min_num_params: 0 | ||
| param_offload: False | ||
| optimizer_offload: False | ||
| fsdp_size: -1 | ||
| ref: | ||
| fsdp_config: | ||
| param_offload: False | ||
| wrap_policy: | ||
| # transformer_layer_cls_to_wrap: None | ||
| min_num_params: 0 | ||
| log_prob_micro_batch_size_per_gpu: 4 | ||
| log_prob_use_dynamic_bsz: ${actor_rollout_ref.actor.use_dynamic_bsz} | ||
| log_prob_max_token_len_per_gpu: ${actor_rollout_ref.actor.ppo_max_token_len_per_gpu} | ||
| ulysses_sequence_parallel_size: ${actor_rollout_ref.actor.ulysses_sequence_parallel_size} # sp size | ||
|
|
||
| trainer: | ||
| balance_batch: True | ||
| # total_training_steps: null | ||
| # auto: find the last ckpt to resume. If can't find, start from scratch | ||
| resume_mode: auto # or auto or resume_path if | ||
| default_hdfs_dir: null | ||
| remove_previous_ckpt_in_save: False | ||
| del_local_ckpt_after_load: False | ||
| val_before_train: False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # TOPR on GSM8K dataset | ||
|
|
||
| This example shows the usage of [TOPR](https://arxiv.org/pdf/2503.14286v1) on the GSM8K dataset, with sync_interval=8. | ||
|
|
||
| The config files are located in [`gsm8k.yaml`](gsm8k.yaml) and [`train_gsm8k.yaml`](train_gsm8k.yaml). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| project: "Trinity-RFT-gsm8k" | ||
| name: "qwen2.5-1.5B-gsm8k-topr" | ||
| checkpoint_root_dir: /PATH/TO/CHECKPOINT/ | ||
| algorithm: | ||
| algorithm_type: topr | ||
| repeat_times: 8 | ||
| model: | ||
| model_path: /PATH/TO/MODEL/ | ||
| max_response_tokens: 1024 | ||
| max_model_len: 1280 | ||
| cluster: | ||
| node_num: 1 | ||
| gpu_per_node: 8 | ||
| buffer: | ||
| total_epochs: 1 | ||
| batch_size: 96 | ||
| explorer_input: | ||
| taskset: | ||
| name: gsm8k | ||
| storage_type: file | ||
| path: 'openai/gsm8k' | ||
| subset_name: 'main' | ||
| split: 'train' | ||
| format: | ||
| prompt_key: 'question' | ||
| response_key: 'answer' | ||
| rollout_args: | ||
| temperature: 1.0 | ||
| eval_tasksets: | ||
| - name: gsm8k-eval | ||
| storage_type: file | ||
| path: 'openai/gsm8k' | ||
| subset_name: 'main' | ||
| split: 'test' | ||
| format: | ||
| prompt_key: 'question' | ||
| response_key: 'answer' | ||
| default_workflow_type: 'math_workflow' | ||
| trainer_input: | ||
| experience_buffer: | ||
| name: gsm8k_buffer | ||
| storage_type: queue | ||
| path: 'sqlite:///gsm8k.db' | ||
| # sft_warmup_steps: 0 | ||
| # sft_warmup_dataset: # Uncomment these to enable sft warmup | ||
| # name: warmup_data | ||
| # storage_type: file | ||
| # path: '/PATH/TO/WARMUP_DATA/' | ||
| explorer: | ||
| eval_interval: 50 | ||
| runner_num: 32 | ||
| rollout_model: | ||
| engine_type: vllm_async | ||
| engine_num: 2 | ||
| tensor_parallel_size: 1 | ||
| enable_prefix_caching: false | ||
| enforce_eager: true | ||
| dtype: bfloat16 | ||
| seed: 42 | ||
| synchronizer: | ||
| sync_method: 'nccl' | ||
| sync_interval: 8 | ||
| sync_timeout: 1200 | ||
| trainer: | ||
| trainer_type: 'verl' | ||
| trainer_config_path: 'examples/topr_gsm8k/train_gsm8k.yaml' | ||
| save_interval: 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| actor_rollout_ref: | ||
| hybrid_engine: True | ||
| model: | ||
| external_lib: null | ||
| override_config: { } | ||
| enable_gradient_checkpointing: True | ||
| use_remove_padding: True # False | ||
| actor: | ||
| strategy: fsdp # This is for backward-compatibility | ||
| ppo_micro_batch_size_per_gpu: 4 | ||
| use_dynamic_bsz: True # False | ||
| ppo_max_token_len_per_gpu: 16384 | ||
| grad_clip: 1.0 | ||
| ppo_epochs: 1 | ||
| shuffle: False | ||
| ulysses_sequence_parallel_size: 1 # sp size | ||
| optim: | ||
| lr: 1e-5 | ||
| lr_warmup_steps_ratio: 0. # the total steps will be injected during runtime | ||
| # min_lr_ratio: null # only useful for warmup with cosine | ||
| warmup_style: constant # select from constant/cosine | ||
| total_training_steps: -1 # must be override by program | ||
| fsdp_config: | ||
| wrap_policy: | ||
| # transformer_layer_cls_to_wrap: None | ||
| min_num_params: 0 | ||
| param_offload: False | ||
| optimizer_offload: False | ||
| fsdp_size: -1 | ||
| ref: | ||
| fsdp_config: | ||
| param_offload: False | ||
| wrap_policy: | ||
| # transformer_layer_cls_to_wrap: None | ||
| min_num_params: 0 | ||
| log_prob_micro_batch_size_per_gpu: 4 | ||
| log_prob_use_dynamic_bsz: ${actor_rollout_ref.actor.use_dynamic_bsz} | ||
| log_prob_max_token_len_per_gpu: ${actor_rollout_ref.actor.ppo_max_token_len_per_gpu} | ||
| ulysses_sequence_parallel_size: ${actor_rollout_ref.actor.ulysses_sequence_parallel_size} # sp size | ||
|
|
||
| trainer: | ||
| balance_batch: True | ||
| # total_training_steps: null | ||
| # auto: find the last ckpt to resume. If can't find, start from scratch | ||
| resume_mode: auto # or auto or resume_path if | ||
| default_hdfs_dir: null | ||
| remove_previous_ckpt_in_save: False | ||
| del_local_ckpt_after_load: False | ||
| val_before_train: False |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| """Reinforce advantage computation""" | ||
|
|
||
| from typing import Dict, List, Tuple | ||
|
|
||
| import torch | ||
|
|
||
| from trinity.algorithm.advantage_fn.advantage_fn import ADVANTAGE_FN, GroupAdvantage | ||
| from trinity.common.experience import Experience, group_by | ||
|
|
||
|
|
||
| @ADVANTAGE_FN.register_module("reinforce") | ||
| class REINFORCEGroupAdvantage(GroupAdvantage): | ||
| """Reinforce Group Advantage computation""" | ||
|
|
||
| def group_experiences(self, exps): | ||
| return group_by(exps, id_type="task") | ||
|
|
||
| def calculate_group_advantage( | ||
| self, group_id: str, exps: List[Experience] | ||
| ) -> Tuple[List[Experience], Dict]: | ||
| with torch.no_grad(): | ||
| rewards = torch.tensor([exp.reward for exp in exps], dtype=torch.float32) | ||
| group_reward_mean = torch.mean(rewards) | ||
| for exp in exps: | ||
| score = torch.tensor(exp.reward, dtype=torch.float32) | ||
| exp.advantages = score * exp.action_mask | ||
| exp.returns = exp.advantages.clone() | ||
|
|
||
| metrics = { | ||
| "reward_mean": group_reward_mean.item(), | ||
| } | ||
| return exps, metrics | ||
|
|
||
| @classmethod | ||
| def default_args(cls) -> dict: | ||
| return {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.