Skip to content

Auto-set pad_token_id when the default is None and not set in the buffer config. #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanxi-chen merged 6 commits into from
Aug 20, 2025
Merged

Auto-set pad_token_id when the default is None and not set in the buffer config. #188

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a4ba577
[Feat] Auto-set missing pad_token_id. Align with Verl and vLLM behavior.
yaochaorui Aug 14, 2025
e433885
[Format]
yaochaorui Aug 14, 2025
486dbbe
[refactor] Move the pad_token_id auto-setting to config.py.
yaochaorui Aug 18, 2025
46cc05d
[fix]
yaochaorui Aug 18, 2025
6f0e63a
[minor]
yaochaorui Aug 20, 2025
192c778
[minor]
yaochaorui Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions trinity/common/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,15 @@ def _check_buffer(self) -> None: # noqa: C901
from transformers import AutoTokenizer

try:
self.buffer.pad_token_id = AutoTokenizer.from_pretrained(
self.model.model_path
).pad_token_id
tokenizer = AutoTokenizer.from_pretrained(self.model.model_path)
if tokenizer.pad_token_id is None:
tokenizer.pad_token_id = tokenizer.eos_token_id
logger.warning(
f"tokenizer.pad_token_id is None. Now set to {tokenizer.eos_token_id}",
stacklevel=1,
)
self.buffer.pad_token_id = tokenizer.pad_token_id

except Exception:
logger.warning(f"Failed to get pad token id from model {self.model.model_path}")
self.buffer.pad_token_id = 0
Expand Down