Fix custom_fields in experiences#191
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses the handling of custom_fields within the Experiences data structure. It modifies the Experiences dataclass to allow for mutable instances, which is essential for dynamically adding custom fields. A new test case has been added to validate the correct gathering of experiences that include custom fields, ensuring that these fields are properly batched and accessible.
Highlights
Experiencesdataclass modification: TheExperiencesdataclass intrinity/common/experience.pyhas been updated by removing thefrozen=Trueattribute. This change allows instances ofExperiencesto be mutable, which is necessary for dynamically adding and managing custom fields.- New test for custom fields: A new test method,
test_gather_experiences_with_custom_fields, has been added totests/common/experience_test.py. This test verifies the functionality ofExperiences.gather_experienceswhen custom fields are provided, ensuring that these fields are correctly batched and accessible within theExperiencesobject.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
/unittest-common |
There was a problem hiding this comment.
Code Review
This pull request introduces support for custom fields in Experiences objects. This is achieved by making the Experiences dataclass mutable and dynamically adding attributes to it. A new test case is added to verify this functionality. My main feedback concerns the design choice of making Experiences mutable, which could have side effects, and I also suggest improving the test coverage for the new feature to handle edge cases.
Summary
Tests
Github Test Reporter by CTRF 💚 |
2 participants
Description
As the title says
Checklist
Please check the following items before code is ready to be reviewed.