Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a significant code cleanup by removing the AddStrategy module. This module has been superseded by a new 'experience pipeline,' making its functionality redundant. The changes involve deleting all files related to AddStrategy and updating relevant documentation to reflect these structural changes and maintain accurate references.
Highlights
- Module Removal: The
AddStrategymodule, along with all its associated classes and implementations (e.g.,GRPOAddStrategy,OPMDAddStrategy,RewardVarianceAddStrategy,CorrectBiasAddStrategy,DuplicateInformativeAddStrategy,StepWiseGRPOStrategy), has been completely removed from the codebase. - Documentation Updates: Documentation files were updated to reflect changes in module structure and to incorporate new Sphinx cross-references, ensuring that the documentation remains accurate and navigable after the code removal.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively removes the AddStrategy module, which has been superseded by the ExperiencePipeline. This is a valuable refactoring that simplifies the architecture by moving logic like advantage calculation into more appropriate components like AdvantageFn. The file deletions are clean, and the accompanying documentation updates correctly reflect the new module paths and add helpful cross-references. The changes are well-implemented and improve the overall codebase.
Collaborator
Author
|
/unittest-all |
Summary
Tests
Github Test Reporter by CTRF 💚 |
chenyushuo
approved these changes
Aug 21, 2025
yaochaorui
pushed a commit
to yaochaorui/Trinity-RFT
that referenced
this pull request
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Experience pipeline replaces the original
AddStrategymodule.Remove the stale code here.
Checklist
Please check the following items before code is ready to be reviewed.