Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the logging infrastructure by introducing actor-level logging for Ray actors within the Trinity-RFT framework. It refactors the core get_logger utility to support dedicated log files for each Ray actor, centralizing log directory and level configuration via environment variables. This change improves log management and debugging in distributed Ray environments.
Highlights
- Actor-Specific Log Files: Each Ray actor now generates its own log file (
{actor_name}.log) within a designated log directory, streamlining debugging in distributed setups. - Centralized Log Configuration: New environment variables (
TRINITY_LOG_DIR,TRINITY_LOG_LEVEL) are introduced to control the log output directory and verbosity globally. - Refactored Logging Utility: The
get_loggerfunction has been updated to be context-aware, automatically configuring file handlers for Ray actors and allowing for dynamic log level settings. - Codebase Cleanup: Redundant logger instantiations and imports were removed across various modules, leading to a cleaner and more consistent logging pattern.
- Comprehensive Test Coverage: A new test file (
tests/utils/log_test.py) has been added to thoroughly validate the new actor-level logging functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant enhancement to the logging system by adding support for Ray actor-level logging. Each actor now logs to its own file, which is a great improvement for debugging distributed components. The implementation correctly uses contextvars to manage logger contexts within actors, and the changes are applied consistently throughout the codebase. The addition of tests is also very good. I've provided a few suggestions for improvement, including a fix for a potential issue in the log level resolution and an enhancement to exception handling.
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/unittest-all |
Summary
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-explorer |
Summary
Tests
Github Test Reporter by CTRF 💚 |
hiyuchang
approved these changes
Aug 25, 2025
Contributor
For holistic understanding of what the system is doing, these are also critical - and maybe upstreaming these at least to Verl (which also is developed fast...) |
yaochaorui
pushed a commit
to yaochaorui/Trinity-RFT
that referenced
this pull request
Aug 27, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #167
Ray-actor-level logging was added in this PR.
Each ray actor will create a file named
{actor_name}.login the{checkpoint_root_dir}/{project}/{name}/logto save its log.Currently actor-level log is only supported by actors created within Trinity-RFT. Actors created by vLLM/veRL are not included.
Checklist
Please check the following items before code is ready to be reviewed.