Bug fix for experience display in wandb#224
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in the trinity/common/models/vllm_model.py file. The core change ensures that the prompt_text value, likely used for logging or display in wandb, accurately reflects the original input prompt rather than a potentially modified or processed version. This fix aims to ensure correct and consistent 'experience' data is recorded and presented.
Highlights
- Bug Fix: Corrected the assignment of
prompt_textintrinity/common/models/vllm_model.pyto use the originalpromptargument instead ofoutput.prompt. This resolves an issue where the displayed prompt text in wandb might have been inaccurate.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where the prompt text was not being correctly stored in the Experience object, which affected its display in wandb. The change correctly uses the prompt string from the generate function. While this is an improvement, I've identified a potential data inconsistency when the prompt is truncated. I've suggested a more robust solution to ensure the stored prompt text always matches the tokens processed by the model, improving data integrity.
|
/unittest-module-common |
Summary
Tests
Github Test Reporter by CTRF 💚 |
2 participants
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.