Add log_table function for mlflow#249
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new capability to log tabular data, specifically pandas DataFrames, to MLflow. This enhancement allows for better tracking and visualization of experimental data, such as experiences or metrics, over different training steps within the MLflow ecosystem.
Highlights
- MLflow Integration: Implemented the
log_tablefunction withintrinity/utils/monitor.pyto enable logging of pandas DataFrames to MLflow. - Data Preparation: Before logging, a 'step' column is added to the input DataFrame, ensuring that the logged data includes the current step information.
- Artifact Logging: The DataFrame is logged as a JSON artifact using
mlflow.log_table, with the artifact file named after the provided table name.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request implements the log_table method for the MlflowMonitor, which was previously a placeholder. The change adds the current step to the provided DataFrame and logs it as a table artifact in MLflow. My review focuses on a potential issue where the input DataFrame is modified in-place, which could lead to unexpected side effects. I've provided a suggestion to address this by creating a copy of the DataFrame before logging, ensuring the function is free of side effects.
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.