Skip to content

Support new task ordering methods#265

Merged
pan-x-c merged 3 commits intoagentscope-ai:mainfrom
HYLcool:feat/new_order_methods
Sep 10, 2025
Merged

Support new task ordering methods#265
pan-x-c merged 3 commits intoagentscope-ai:mainfrom
HYLcool:feat/new_order_methods

Conversation

@HYLcool
Copy link
Collaborator

@HYLcool HYLcool commented Sep 9, 2025

Description

Support 4 task ordering methods:

  • keep: keep the original order.
  • shuffle: randomly shuffle the task order.
  • sort: sort the tasks according to their priority score.
  • folding: folding the tasks into L layers after they are sorted. Ref: https://arxiv.org/abs/2506.21545

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@HYLcool HYLcool requested review from pan-x-c and yxdyc September 9, 2025 13:34
@HYLcool HYLcool self-assigned this Sep 9, 2025
@HYLcool HYLcool added the enhancement New feature or request label Sep 9, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @HYLcool, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the data processing pipeline by adding flexible task ordering capabilities. It allows users to specify how datasets are arranged after initial processing, supporting various strategies from simple shuffling to advanced curriculum learning techniques, thereby improving the adaptability of the system to different data handling requirements.

Highlights

  • New Task Ordering Methods: Introduced four distinct methods for ordering tasks: 'keep' (original order), 'shuffle' (random order), 'sort' (by priority score), and 'folding' (a method inspired by curriculum learning, arranging tasks into layers after sorting).
  • Configurable Ordering: The chosen task ordering method and its specific arguments (e.g., 'folding_layers') are now configurable via the DJConfig class, providing flexibility for users.
  • Refactored Task Processing: The logic for applying task ordering has been encapsulated into a new order_task method within the Session class, improving modularity and readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new task ordering methods, which is a great addition for controlling the data curriculum. The implementation is mostly solid, but I've identified a few areas for improvement. My feedback includes fixing a potential bug with default dictionary handling, improving code consistency by applying the top_k parameter to the folding method, reducing code duplication, and adding type hints for better readability. Addressing these points will make the new feature more robust and maintainable.

@HYLcool
Copy link
Collaborator Author

HYLcool commented Sep 9, 2025

/unittest-module-service

@github-actions
Copy link

github-actions bot commented Sep 9, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
4 4 0 0 0 0 63ms

Tests

Test Name Status Flaky Duration
tests/service/data_juicer_test.py::TestDataJuicer::test_config 1ms
tests/service/data_juicer_test.py::TestDataJuicer::test_server_start 21ms
tests/service/data_juicer_test.py::TestDataJuicerExperiencePipeline::test_data_juicer_operators 24ms
tests/service/data_juicer_test.py::TestDataJuicerTaskPipeline::test_data_juicer_task_pipeline 14ms

Github Test Reporter by CTRF 💚

@pan-x-c pan-x-c merged commit 412497f into agentscope-ai:main Sep 10, 2025
1 check passed
@HYLcool HYLcool deleted the feat/new_order_methods branch September 10, 2025 03:16
yaochaorui pushed a commit to yaochaorui/Trinity-RFT that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants