Skip to content

Update data-juicer version in toml#286

Merged
chenyushuo merged 1 commit intoagentscope-ai:mainfrom
chenyushuo:fix/update_dj_in_toml
Sep 18, 2025
Merged

Update data-juicer version in toml#286
chenyushuo merged 1 commit intoagentscope-ai:mainfrom
chenyushuo:fix/update_dj_in_toml

Conversation

@chenyushuo
Copy link
Collaborator

Description

As the title says.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating and refining project dependencies within the pyproject.toml file. The primary goal is to ensure compatibility and leverage newer versions of key libraries, specifically py-data-juicer, and to adjust dependency overrides to resolve potential conflicts with other components like rm-gallery.

Highlights

  • Dependency Update: The py-data-juicer dependency has been updated from version 1.4 to 1.4.3 in the pyproject.toml file.
  • Dependency Override Change: The override-dependencies configuration under [tool.uv] in pyproject.toml has been changed from spacy>=3.8.2 to math_verify>=0.8.0, along with an updated comment explaining the reason for the override.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the py-data-juicer dependency and modifies the uv dependency overrides. While the changes seem logical, replacing the spacy override entirely could potentially cause issues if it's still needed. I've added a comment with a suggestion to combine the overrides to prevent potential installation problems and improve readability.

@chenyushuo chenyushuo merged commit 3294803 into agentscope-ai:main Sep 18, 2025
1 check passed
yaochaorui pushed a commit to yaochaorui/Trinity-RFT that referenced this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments