Update data-juicer version in toml#286
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating and refining project dependencies within the pyproject.toml file. The primary goal is to ensure compatibility and leverage newer versions of key libraries, specifically py-data-juicer, and to adjust dependency overrides to resolve potential conflicts with other components like rm-gallery.
Highlights
- Dependency Update: The
py-data-juicerdependency has been updated from version1.4to1.4.3in thepyproject.tomlfile. - Dependency Override Change: The
override-dependenciesconfiguration under[tool.uv]inpyproject.tomlhas been changed fromspacy>=3.8.2tomath_verify>=0.8.0, along with an updated comment explaining the reason for the override.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the py-data-juicer dependency and modifies the uv dependency overrides. While the changes seem logical, replacing the spacy override entirely could potentially cause issues if it's still needed. I've added a comment with a suggestion to combine the overrides to prevent potential installation problems and improve readability.
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.