Merged
Conversation
2. Remove empty path in experience_buffer. 3. Improved the situation where the `storage_config.path` is empty.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @chenyushuo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refines the system's configuration by eliminating deprecated or unnecessary parameters and enhancing the handling of storage buffer paths. These changes aim to streamline configuration management, prevent potential issues arising from empty path values, and improve the overall robustness of the configuration loading process.
Highlights
- Configuration Cleanup: The
val_before_trainparameter has been removed from various configuration files, simplifying the trainer settings. - Experience Buffer Path Handling: Empty
pathentries for theexperience_bufferare now explicitly removed from configuration, and the logic for checking empty paths in storage buffers has been improved. - Robust Path Validation: The code now uses a more robust check (
if not storage_config.path) for empty paths inFileStorageandQueueBufferinitialization, ensuring proper default path assignment.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several improvements to configuration handling. It successfully removes the deprecated val_before_train option from various configuration files and documentation. It also improves the handling of the experience_buffer path by removing empty path definitions and making the code more robust to handle both None and empty string values for paths. The changes are consistent and well-implemented. I have one suggestion to refactor a section of the code to improve maintainability.
2. Rename `model_type` to `engine_type` and remove `vllm_async`
Collaborator
Author
|
/unittest-module-common |
Summary
Failed Tests
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a series of valuable improvements to the configuration handling and codebase structure. The removal of deprecated or empty configuration fields like val_before_train and empty path attributes cleans up the configuration files and is consistently applied across templates and documentation. The dependency update for rm-gallery and the removal of the corresponding uv override is a welcome cleanup. The renaming of model_type to engine_type is applied consistently throughout the codebase, including tests. The most significant improvement is the refactoring within trinity/common/config.py, where the introduction of the set_if_none helper function and the use of local variables to shorten long attribute chains have greatly enhanced code readability and maintainability. Overall, this is a high-quality pull request with well-executed changes that improve the project's health.
Collaborator
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
approved these changes
Sep 19, 2025
yaochaorui
pushed a commit
to yaochaorui/Trinity-RFT
that referenced
this pull request
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
val_before_trainin config.storage_config.pathis empty.py_executable: "uv run"#253model_typetoengine_typeand removevllm_asyncmax_tokenstoGenerationConfig.Checklist
Please check the following items before code is ready to be reviewed.