Explorer provides OpenAI API compatible inference service#289
Merged
yanxi-chen merged 14 commits intoagentscope-ai:mainfrom Sep 22, 2025
Merged
Explorer provides OpenAI API compatible inference service#289yanxi-chen merged 14 commits intoagentscope-ai:mainfrom
yanxi-chen merged 14 commits intoagentscope-ai:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Summary of Changes
Hello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a significant new 'serve' mode for the Explorer component, transforming it into an OpenAI API-compatible inference service. This enhancement allows external agent applications to leverage the Explorer's capabilities remotely for inference, offering features like dynamic request routing, automatic experience data capture, and continuous model weight synchronization. The changes ensure high availability and efficient resource utilization while providing a standardized API interface for interaction.
Highlights
- New 'serve' mode for Explorer: Introduced a dedicated 'serve' mode for the Explorer component, allowing it to function as an OpenAI API-compatible inference service. This mode is designed for agent applications to deploy locally and utilize remote Explorer services.
- OpenAI API Compatibility: The Explorer now provides an API that is compatible with OpenAI's API, enabling seamless integration with existing OpenAI client libraries.
- Dynamic Request Assignment and Load Tracking: Explorer dynamically assigns incoming inference requests to available models and includes
--enable-server-load-trackingfor better load balancing. - Automatic Experience Data Conversion: In 'serve' mode, inference requests and responses are automatically converted into 'Experience' data and written to an internal buffer for further processing.
- Continuous Model Weight Synchronization: The Explorer continuously tracks the latest model checkpoints via a Synchronizer and updates the inference models' weights, ensuring models are always up-to-date.
- Service Availability Guarantee: The system ensures that at least one inference model remains in a running state at all times, even during weight synchronization, to maintain uninterrupted service.
- New API and Server Modules: Two new modules,
trinity/explorer/api/api.pyandtrinity/explorer/api/server.py, were added to implement the FastAPI-based API server and its management logic. - Explorer Client for API Interaction: A new
ExplorerClient(trinity/explorer/explorer_client.py) was introduced to facilitate interaction with the Explorer's API server, including session management and patched OpenAI client methods.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant new feature: a serve mode for the Explorer, which provides an OpenAI-compatible API for inference. The changes are extensive, touching configuration, model wrappers, the explorer's core logic, and adding new API server components. My review has focused on the correctness and robustness of this new functionality. I have identified several critical issues in the API server implementation that would likely cause runtime errors, as well as a major logical flaw where data collected via the API is not processed. Additionally, I've provided suggestions to improve error handling, logging practices, and the API client implementation. Addressing these findings will be essential to ensure the stability and correctness of the new serve mode.
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/unittest-all |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
changed the title
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-common |
Summary
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-trainer |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
yanxi-chen
approved these changes
Sep 22, 2025
Closed
yaochaorui
pushed a commit
to yaochaorui/Trinity-RFT
that referenced
this pull request
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propose
servemode in this PR.In
servemodebuffer.explorer_inputwill be ignored.Experiencedata and write them to buffer.With
servemode, agent application developers can deploy their Agent applications locally and use the inference services provided by a remote Explorer.Checklist
Please check the following items before code is ready to be reviewed.