Skip to content

Fix Bug: group_rewards Un-assigned value #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pan-x-c merged 4 commits into from
Oct 27, 2025
Merged

Fix Bug: group_rewards Un-assigned value #343

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f2a615
Fix Bug: group_rewards Un-assigned value
Oct 27, 2025
547adf1
Fix Bug: group_rewards Un-assigned value
Oct 27, 2025
60b8c5c
Merge branch 'modelscope:main' into featureB
shiweijiezero Oct 27, 2025
d7c85eb
Format code
Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions trinity/algorithm/advantage_fn/opmd_advantage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,13 @@ def calculate_group_advantage(
self, group_id: str, exps: List[Experience]
) -> Tuple[List[Experience], Dict]:
with torch.no_grad():
group_rewards = torch.tensor([exp.reward for exp in exps], dtype=torch.float32)
reward_mean = torch.mean(group_rewards)
if len(exps) == 1:
group_baseline = torch.tensor(0.0)
else:
group_rewards = torch.tensor([exp.reward for exp in exps], dtype=torch.float32)
if self.opmd_baseline == "mean":
group_baseline = torch.mean(group_rewards)
group_baseline = reward_mean
else:
group_baseline = self.tau * (
torch.logsumexp(group_rewards / self.tau, dim=-1)
Expand All @@ -136,7 +137,7 @@ def calculate_group_advantage(
exp.returns = exp.advantages.clone()
metrics = {
"group_baseline": group_baseline.item(),
"reward_mean": torch.mean(group_rewards).item(),
"reward_mean": reward_mean.item(),
}
return exps, metrics

Expand Down