Enable System Metrics Recording in MLFLOW#362
Conversation
Summary of ChangesHello @hiyuchang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates MLflow's system metrics logging feature into the project. By activating this functionality, the system will automatically capture and record crucial performance metrics such as CPU and memory usage during MLflow experiments, offering a more complete operational context for model development and analysis. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enables system metrics recording for MLflow. While the feature is useful, the current implementation enables it globally at the module import level, which can cause unintended side effects for users of the library who may not be using the MlflowMonitor. My review suggests moving this logic into the MlflowMonitor's initializer to scope the behavior correctly and make it active only when the MLflow monitor is explicitly used.
c2e29a3 to
20769c2
Compare
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.