Merged
Conversation
Contributor
Summary of ChangesHello @pan-x-c, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on updating the system's integration with vLLM to support its latest versions, 0.13.0 and 0.14.0. It involves a significant refactoring of how the vLLM API server is initialized, introducing a more modular and version-aware approach. This ensures that the system can leverage the performance and features of newer vLLM releases while maintaining stability and correct functionality across different versions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for vLLM versions v0.13.0 and v0.14.0. The core change involves refactoring the API server initialization to dynamically load version-specific patches based on the detected vLLM version. A new api_patch_v13.py file has been added to handle the API changes in vLLM versions 0.13.0 and above, and existing version compatibility ranges in worker_patch.py have been updated accordingly. This approach enhances maintainability by centralizing version-dependent logic and ensures compatibility with newer vLLM releases. The changes are well-implemented and align with the stated objective of the pull request.
Collaborator
Author
|
/unittest-module-common |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-common |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-module-common |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for vLLM versions up to 0.14.1, which is a valuable update. The changes are well-structured, with version-specific logic correctly encapsulated in patch files. The refactoring to use a factory function get_api_server for creating the API server is a good improvement for maintainability.
I've added one suggestion to improve code clarity in the new api_patch_v13.py file.
Additionally, I've noticed a potential bug that I couldn't comment on directly due to tooling limitations. The file scripts/install.py was renamed to scripts/data/install.py, but unlike the similar change in scripts/data/start_servers.py, the relative path to env_mapping.json was not updated. This will likely cause a FileNotFoundError when running scripts/data/install.py. Please ensure this path is corrected.
Overall, great work on extending vLLM support.
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
hiyuchang
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for vLLM v0.13.0, v0.14.0, v0.14.1
Checklist
Please check the following items before code is ready to be reviewed.