Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity Hub - Handle Base64Url decoding/encoding of the data field #14

Closed
3 tasks
Tracked by #13
ouphi opened this issue Jun 24, 2022 · 2 comments
Closed
3 tasks
Tracked by #13

Identity Hub - Handle Base64Url decoding/encoding of the data field #14

ouphi opened this issue Jun 24, 2022 · 2 comments
Assignees

Comments

@ouphi
Copy link

ouphi commented Jun 24, 2022

Feature #13

Description

Make sure that the data field in MessageRequestObject is base64URL encoded and decoded.
Jackson automatically base64 encode/decode, but base64URL should be verified.

Acceptance criteria

  • The data field in MessageRequestObject is base64URL encoded and decoded

Tasks

  • Check if the byte[] are already automatically base64URL encoded or not
  • If it is not the case, add the decoding and decoding.
@zeier
Copy link

zeier commented Jun 29, 2022

Assigning to @ouphi to add description, acceptance criteria and tasks.

@zeier zeier added story and removed team review labels Jul 7, 2022
@zeier zeier unassigned ouphi Jul 7, 2022
@ouphi ouphi transferred this issue from agera-edc/MinimumViableDataspace Jul 7, 2022
@zeier zeier moved this from Ready to Planned in Agera EDC Jul 13, 2022
@zeier zeier removed the status in Agera EDC Jul 13, 2022
@zeier zeier moved this to Ready in Agera EDC Jul 13, 2022
marcgs added a commit that referenced this issue Jul 28, 2022
* Identity Hub CLI

* Add test for buildSignedJwt

* Rename test util class for CLI

* Consolidate test

* Remove unused import

* Checkstyle

* Make test fields private

* Reduce visibility of util class

* Checkstyle

* Make static variables final
@ouphi ouphi self-assigned this Aug 9, 2022
@ouphi
Copy link
Author

ouphi commented Aug 9, 2022

Closing this story because the data field is a JWT and already base64Url encoded.

@ouphi ouphi closed this as completed Aug 9, 2022
Repository owner moved this from Ready to Done in Agera EDC Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants