Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IdentityHub - Get and verify credentials #24

Closed
5 of 6 tasks
Tracked by #13
ouphi opened this issue Jul 4, 2022 · 0 comments
Closed
5 of 6 tasks
Tracked by #13

IdentityHub - Get and verify credentials #24

ouphi opened this issue Jul 4, 2022 · 0 comments
Assignees
@marcgs @ouphi
Labels
identity-hub story

Comments

@ouphi
Copy link

ouphi commented Jul 4, 2022 •
edited by marcgs
Loading

Feature #13

Description

During IDS communication between 2 participants, before applying access policy, a participant needs to:

  • Get the other participant's verifiableCredentials from IdentityHub
  • Verify the signature of each verifiableCredential
  • Extract the claims of a participant.

This story is about implementing this logic.

A CredentialVerifier contract is defined in EDC.

The contract of the CredentialVerifier needs to be changed according to the ADR.

Some resource:
Here is an example of a CredentialVerifier here retrieving Verifiable Credentials in the DecentralizedIdentityService. This is a quick implementation done before.

Acceptance criteria

  • Logic to verifyCredentials is implemented
  • Logic to extract the claims is implemented
  • CredentialVerifier is adapted to the new contract

Tasks

  • Implement custom CredentialVerifier
  • Update CredentialVerifier contract in EDC
  • Adapt ITs
@zeier zeier mentioned this issue Jul 7, 2022
Closed
19 tasks
@ouphi ouphi self-assigned this Jul 4, 2022
@ouphi ouphi transferred this issue from agera-edc/MinimumViableDataspace Jul 7, 2022
@ouphi ouphi mentioned this issue Jul 7, 2022
Closed
7 tasks
@ouphi ouphi moved this from In Progress to In Review in Agera EDC Jul 20, 2022
@ouphi ouphi changed the title IdentityHub - Get claims IdentityHub - Get and verify credentials Jul 20, 2022
@marcgs marcgs self-assigned this Jul 26, 2022
@marcgs marcgs moved this from In Review to In Review Upstream in Agera EDC Jul 26, 2022
@chrislomonico chrislomonico moved this from In Review Upstream to Done in Agera EDC Jul 26, 2022
@marcgs marcgs closed this as completed Jul 26, 2022
@paullatzelsperger paullatzelsperger mentioned this issue Aug 12, 2022
Closed
1 task
bscholtes1A pushed a commit that referenced this issue Aug 12, 2022
@ouphi
feat: IdentityHubCredentialsVerifier Fails if one VC signature verifi…
2c99152 
…cation fails (#24)

* IdentityHubCredentialsVerifier fails if credential is invalid (#49)

* IdentityHubCredentialsVerifier: Fails if one VC signature verification fails

IdentityHubCredentialsVerifier: Fails if one VC signature verification fails

* Applied comments. Added Override.

* Removed mergeFailureMessages method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcgs marcgs

@ouphi ouphi

Labels
identity-hub story
Projects
Agera EDC
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcgs @ouphi