Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/21/21 verifier maven #34

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

algattik
Copy link

@algattik algattik commented Jul 27, 2022

What this PR changes/adds

Publish IdentityHub Credentials Verifier to Maven, so that it can be used in MVD EDC.

Why it does that

Further notes

Also removed unused setting.

Linked Issue(s)

#21

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

algattik and others added 2 commits July 27, 2022 17:08
Co-Authored-By: Alexandre Gattiker <algattik@users.noreply.github.com>
Co-Authored-By: Alexandre Gattiker <algattik@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Jul 27, 2022

Unit Test Results

40 tests  ±0   40 ✔️ ±0   7s ⏱️ -2s
  9 suites ±0     0 💤 ±0 
  9 files   ±0     0 ±0 

Results for commit 46c3477. ± Comparison against base commit 57c7c3d.

♻️ This comment has been updated with latest results.

@algattik algattik marked this pull request as ready for review July 27, 2022 15:48
.
Co-Authored-By: Alexandre Gattiker <algattik@users.noreply.github.com>
@algattik algattik marked this pull request as draft July 27, 2022 20:03
@algattik algattik marked this pull request as ready for review July 28, 2022 06:50
Copy link

@cpeeyush cpeeyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a question about settings removal.

@algattik algattik merged commit a29ab3f into feature/21-verifier-maven Jul 28, 2022
@algattik algattik deleted the feature/21/21-verifier-maven branch July 28, 2022 11:42
ouphi pushed a commit that referenced this pull request Jul 29, 2022
* Feature/21/21 verifier maven (#34)

* checkstyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants