Document the format of the credentials returned by the IdentityHubCredentialsVerifier. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouphi
changed the title
cpeeyush
reviewed
Jul 29, 2022
...java/org/eclipse/dataspaceconnector/identityhub/verifier/IdentityHubCredentialsVerifier.java
Outdated
Show resolved
Hide resolved
cpeeyush
approved these changes
Jul 29, 2022
algattik
requested changes
Jul 29, 2022
docs/developer/decision-records/2022-07-01-get-claims/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2022-07-01-get-claims/README.md
Outdated
Show resolved
Hide resolved
docs/developer/decision-records/2022-07-01-get-claims/README.md
Outdated
Show resolved
Hide resolved
bscholtes1A
reviewed
Aug 2, 2022
| The IdentityHubCredentialsVerifier returns a Map<String, Object>, it contains verifiable credentials with the following format: | ||
|
|
||
| ```json | ||
| <verifiable-credential-id>: { |
There was a problem hiding this comment.
Cant we have more than one VC for a given verifiable-credential-id? For example if we are dealing with multiple VC issuers.
If yes, we can have a List. Maybe an example for illustrating this case?
There was a problem hiding this comment.
The goal of this PR is to document the format that is already used, but I agree that it could be simplified by using a List later.
Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com>
algattik
reviewed
Aug 5, 2022
...java/org/eclipse/dataspaceconnector/identityhub/verifier/IdentityHubCredentialsVerifier.java
Show resolved
Hide resolved
algattik
approved these changes
Aug 5, 2022
ouphi
added a commit
that referenced
this pull request
Aug 9, 2022
…ubCredentialsVerifier. (#36) (#17) * Documented claims format. * improved explanations. * Update docs/developer/decision-records/2022-07-01-get-claims/README.md Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com> * Added subject in doc. * Made the json format valid. * Added information about the credentialSubject field. * Added @code. * Used pre . Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com> Co-authored-by: Alexandre Gattiker <algattik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Document the format of the Map<String, Object> returned by the IdentityHubCredentialsVerifier.
Linked Issue(s)
Closes # <-- insert Issue number if one exists
Checklist
no-changelog)