Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/14/14 Registration Service JWS authentication #178

Merged
merged 24 commits into from
Jul 27, 2022

Conversation

algattik
Copy link

@algattik algattik commented Jul 1, 2022

What this PR changes/adds

Access to the Registration Service API is authenticated with JWS. Adapted accordingly:

  • the Registration Service CLI call in the deployment pipeline
  • the federated Directory implementation in EDC, for retrieving the participants list

Why it does that

Authentication ensures that only actors who can assert their control of a did:web identifier can register that identifier as a dataspace participant.

Further notes

  • Updated Registration service commit dependency for the required JWS support
  • Updated Registration service URLs given new port and URL mapping (Feature/14/14 web context (with ADR) RegistrationService#14)
  • Updated EDC version because of a required fix (#1575)
  • The curl command to check registration service is up doesn't work anymore, since a JWS is required. I've remove the curl command and let the workflow fail when deploying participants. Other options could be pursued in follow-up issues, e.g.:
    • adapt the curl command to succeed if a 401 is returned and fail otherwise
    • use the CLI client list participants command with the authority key
    • use az container show to check state=running (based on internal health check), waiting if necessary
    • use az container exec to run curl within the container, waiting if necessary
    • expose port 8181
    • use Terratest
  • Also changed workflow trigger to run on all PRs, not only to main branch, to facilitate downstream fork process.

Linked Issue(s)

#14

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@algattik algattik force-pushed the feature/14/14-rs-jws branch from 5f7795c to c3daa46 Compare July 1, 2022 11:44
@cpeeyush cpeeyush marked this pull request as ready for review July 15, 2022 10:30
@chrislomonico chrislomonico requested review from marcgs and Izzzu July 18, 2022 08:42
@cpeeyush cpeeyush marked this pull request as draft July 18, 2022 11:12
@chrislomonico chrislomonico self-requested a review July 19, 2022 14:28
@algattik algattik marked this pull request as ready for review July 20, 2022 07:05
@algattik algattik changed the title Feature/14/14 rs jws Feature/14/14 Registration Service JWS authentication Jul 20, 2022
@cpeeyush cpeeyush self-requested a review July 20, 2022 08:37
@cpeeyush cpeeyush mentioned this pull request Jul 20, 2022
7 tasks
@cpeeyush cpeeyush force-pushed the feature/14/14-rs-jws branch from d6f519f to e8c73a4 Compare July 25, 2022 07:25
@algattik algattik force-pushed the feature/14/14-rs-jws branch from e8c73a4 to 0ef7d81 Compare July 27, 2022 05:21
@algattik algattik force-pushed the feature/14/14-rs-jws branch from 0ef7d81 to 38d4af3 Compare July 27, 2022 11:53
@cpeeyush cpeeyush force-pushed the feature/14/14-rs-jws branch from 38d4af3 to caf9630 Compare July 27, 2022 12:14
@cpeeyush cpeeyush force-pushed the feature/14-rs-jws branch from bbdc7f2 to 9362f36 Compare July 27, 2022 12:16
@cpeeyush cpeeyush merged commit e612bb9 into feature/14-rs-jws Jul 27, 2022
@zeier zeier linked an issue Aug 2, 2022 that may be closed by this pull request
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registration Service - Participant onboarding- Verifies participant JWS
5 participants