forked from eclipse-edc/MinimumViableDataspace
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/14/14 Registration Service JWS authentication #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
algattik
force-pushed
the
feature/14/14-rs-jws
branch
from
July 1, 2022 11:44
5f7795c
to
c3daa46
Compare
algattik
changed the title
Feature/14/14 rs jws
Feature/14/14 Registration Service JWS authentication
Jul 20, 2022
7 tasks
cpeeyush
reviewed
Jul 20, 2022
cpeeyush
approved these changes
Jul 20, 2022
chrislomonico
approved these changes
Jul 20, 2022
Izzzu
reviewed
Jul 20, 2022
algattik
force-pushed
the
feature/14/14-rs-jws
branch
from
July 21, 2022 14:21
dd2a385
to
5e65bc0
Compare
cpeeyush
force-pushed
the
feature/14/14-rs-jws
branch
from
July 22, 2022 15:30
5c7c3fc
to
7cdb94e
Compare
paullatzelsperger
approved these changes
Jul 25, 2022
cpeeyush
force-pushed
the
feature/14/14-rs-jws
branch
from
July 25, 2022 07:25
d6f519f
to
e8c73a4
Compare
algattik
force-pushed
the
feature/14/14-rs-jws
branch
from
July 27, 2022 05:21
e8c73a4
to
0ef7d81
Compare
… script differences
…stration script differences" This reverts commit ad83173.
Use docker for cli tools add execute permission explicitly
algattik
force-pushed
the
feature/14/14-rs-jws
branch
from
July 27, 2022 11:53
0ef7d81
to
38d4af3
Compare
cpeeyush
force-pushed
the
feature/14/14-rs-jws
branch
from
July 27, 2022 12:14
38d4af3
to
caf9630
Compare
cpeeyush
force-pushed
the
feature/14-rs-jws
branch
from
July 27, 2022 12:16
bbdc7f2
to
9362f36
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Access to the Registration Service API is authenticated with JWS. Adapted accordingly:
Why it does that
Authentication ensures that only actors who can assert their control of a did:web identifier can register that identifier as a dataspace participant.
Further notes
#1575
)curl
command and let the workflow fail when deploying participants. Other options could be pursued in follow-up issues, e.g.:curl
command to succeed if a401
is returned and fail otherwiselist participants
command with the authority keyaz container show
to checkstate=running
(based on internal health check), waiting if necessaryaz container exec
to runcurl
within the container, waiting if necessaryLinked Issue(s)
#14
Checklist
no-changelog
)