Feature/179 scaffold #1
Conversation
This reverts commit be007f3.
| } | ||
| configurations { | ||
| all { | ||
| exclude(group = "com.fasterxml.jackson.jaxrs", module = "jackson-jaxrs-json-provider") |
There was a problem hiding this comment.
no, but that's how it is in EDC and removing it gives a missing dependency error
| @Produces({"application/json"}) | ||
| @Consumes({"application/json"}) | ||
| @Path("/health") | ||
| public class HealthApiController { |
There was a problem hiding this comment.
Did you consider using EDC's ObservabilityApiController?
There was a problem hiding this comment.
Good point, I did want to add a custom controller to show how it's done, but this can be a follow-up story after we have more controllers.
There was a problem hiding this comment.
|
|
||
| @Target({ElementType.TYPE, ElementType.METHOD}) | ||
| @Retention(RetentionPolicy.RUNTIME) | ||
| @EnabledIfEnvironmentVariable(named = "INTEGRATION_TEST", matches = "true") |
There was a problem hiding this comment.
- we can add a follow up story to add doc about details on how to run integration test.
- And also, a system test README explaining that project needs to be build first to generate executable jar
./build/libs/app.jarand then only docker-compose will work locally.
Both of these items can be done in a follow-up story.
There was a problem hiding this comment.
Added system test README.md
...in/java/org/eclipse/dataspaceconnector/registration/api/RegistrationServiceApiExtension.java
Show resolved
Hide resolved
|
|
||
| @IntegrationTest | ||
| public class HealthApiClientTest { | ||
| static final String API_URL = "http://localhost:8181/api"; |
There was a problem hiding this comment.
very nit: maybe we can read it from environment variables and keep this one as default. or we can do it later as well when we extend the test to verify health endpoint of a deployed one.
There was a problem hiding this comment.
Yes I first had a version with env var, but then I removed it along the principle to only implement things once we have a clear need for them :)
Feature/178 reg repo migration
Creates scaffold Registry service web service as an EDC runtime with simple health endpoint.
CI pipeline builds the registration service and runs it in docker. A system test runs an HTTP request as a client to validate the build.
Closes https://github.com/agera-edc/MinimumViableDataspace/issues/179
On naming, we use
org.eclipse.dataspaceconnector.registrationsince the repo will live in the https://github.com/eclipse-dataspaceconnector organization.