Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 14 - extends kernel configuration #110

Closed
wants to merge 2 commits into from
Closed

Fix issue 14 - extends kernel configuration #110

wants to merge 2 commits into from

Conversation

andig75
Copy link
Contributor

@andig75 andig75 commented Aug 20, 2017

This patch fixes issues #14

I have updated the patch available in the mailing list and with this patch is possible to extend the kernel configuration via bbappend and cfg fragments.

@jenkins-ag
Copy link

Can one of the admins verify this patch?

@andig75 andig75 changed the title Fixed issue 14 - extends kernel configuration Fix issue 14 - extends kernel configuration Aug 20, 2017
@agherzan
Copy link
Owner

agherzan commented Aug 23, 2017

It looks good. Could you please fix the commit log accordingly to http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines . Something like "linux-raspberrypi: Fix kernel configuration using cfg files" and use a recommended line size of 78 chars?

In tree configurations are now used to build the kernel and
it is possible to extend the config via bbappend and cfg fragments

Fix issue 14

Signed-off-by: Andrea Ghittino <aghittino@gmail.com>
@andig75
Copy link
Contributor Author

andig75 commented Aug 23, 2017

@agherzan I have changed the comment
Please let me know if it is ok

@agherzan
Copy link
Owner

It is just fine. Thanks for this. There is though one more change needed. Builds got broken due to a bbappend getting invalid. This was fixed in master. Could you please rebase this PR for the build server to be able to pass the issue currently fixed in master?

@andig75
Copy link
Contributor Author

andig75 commented Aug 25, 2017

@agherzan , please let me know if now it is ok, or if something is still missing

@agherzan
Copy link
Owner

Could you please rebase your branch on top of master and remove the merge branch you curently have? Everything else looks good now.

@andig75
Copy link
Contributor Author

andig75 commented Aug 29, 2017

I have just created a new PR based on latest master.
I close this one. The diff is the same

@andig75 andig75 closed this Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants