Implement config, update search options #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
July 23, 2024 17:25
michquinn
requested changes
Dec 8, 2024
src/config/Config.ts
Outdated
|
|
||
| // Private Properties | ||
| #configFolder: string = "./"; | ||
| #port: number = 8084; |
There was a problem hiding this comment.
See system port number specifications here: https://github.com/agile-learning-institute/mentorHub/blob/main/specifications/architecture.yaml. Basically all the API's are eventually served from the same host, just at different port numbers.
There was a problem hiding this comment.
I'm still unclear as to why it's 8084 here and 8081 elsewhere in the file. Isn't 8084 for the partner API?
There was a problem hiding this comment.
you are correct, will fix this
There was a problem hiding this comment.
OH - that is an un-needed initialization, it is over-ridden as the default on line 43 - I chaned this to 0
michquinn
approved these changes
Dec 8, 2024
…search-api into implement-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor implements a seperation of concerns, jest unit testing, and stepci end-to-end testing.
Seperation of concerns
/src/config - Configuration Code
/src/controllers - HTTP request/reply handlers
/src/services - Service layer for RBAC and Business Logic
/src/store - ElastiicIO wrapper
/src/server.ts - Entrypoint to Initilize and Run Server
closes #15
closes #4
closes #13
NOTE: These changes are dependent on code from PR's on the mentorhub and mentorhub-elasticsearch repo's. To test locally you will need to
make installto get docker-compose updatesnpm run container- new initializeYou should then be able to run
npm run containerandnpm run stepcito see the API in action.