Skip to content

Commit

Permalink
fix: fix rendering issue in Firefox
Browse files Browse the repository at this point in the history
This fix moves the responsibility of the rendering into the extension, rather than the mule-preview
plugin. An issue was uncovered  where the latest version of React (16.9.0) does not work in Firefox
browser extensions due to a change to the scheduler (facebook/react#16606)
so React was downgraded. After those fixes were implemented, the issue with rendering only working
correctly the second time the extension was triggered was fixed.

fix #72
  • Loading branch information
Sean Dawson committed Sep 21, 2019
1 parent eb429d3 commit 8b3ff60
Show file tree
Hide file tree
Showing 6 changed files with 4,910 additions and 4,829 deletions.
3 changes: 2 additions & 1 deletion .babelrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"presets": [
["@babel/preset-env", { useBuiltIns: "usage", corejs: 3 }]
["@babel/preset-env", { "useBuiltIns": "usage", "corejs": 3 }],
"@babel/preset-react"
],
"plugins": [
"@babel/plugin-syntax-dynamic-import",
Expand Down
6 changes: 5 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
{
"extends": ["eslint:recommended", "plugin:prettier/recommended"],
"extends": [
"eslint:recommended",
"plugin:react/recommended",
"plugin:prettier/recommended"
],
"env": {
"browser": true,
"commonjs": true,
Expand Down
Loading

0 comments on commit 8b3ff60

Please sign in to comment.