Add support for non-camelCase function names #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dspasojevic
reviewed
Jan 30, 2024
| @@ -345,7 +345,7 @@ Usage | |||
| `); | |||
| } | |||
|
|
|||
| const funcNamePascalCase = pascalCase(funcName); | |||
| const funcNamePascalCase = this.serverless.providers.aws.naming.getNormalizedFunctionName(funcName); | |||
There was a problem hiding this comment.
polish: in addition to @NoxHarmonium's more substantive feedback, it would be great to rename the variable to reflect that it will be config-driven normalisation.
Suggested change
| const funcNamePascalCase = this.serverless.providers.aws.naming.getNormalizedFunctionName(funcName); | |
| const funcNameNormalised = SOME_CONFIG_CHECK ? this.serverless.providers.aws.naming.getNormalizedFunctionName(funcName) : pascalCase(funcName); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a function is named with dashes for example, it would currently create an invalid name for the sqs queue as it has to be alphanumerical