Synthetics Bugs #152
Open
Synthetics Bugs #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor update to make_synthetic
Added 1 more alias for SGRC from some GOM wells.
…tions-drop-36 Remove Py 3.6 from CI and update actions
make `defaults` on global namespace
Update AUTHORS.md info
Update defaults.py
…rned by fill_betweenx
…en renamed append_curve
…nd-curve-bug Fixed a bug where lasio no longer has the method add_curve.
…ecated_access Fix/curve deprecated access
…d-hatch Modern build system using Importlib and hatch
…urve Fix plot 2d curve
…cation Fix Pandas deprecations
|
I've reviewed this in light of the newer updates and the synthetic issues remain. This should merge into the existing code without any issues I could identify. |
frank1010111
reviewed
Dec 9, 2024
|
Frank - I've reviewed this based on your comments and updated the as_curve function to eliminate the Nones. Added a few conditionals to account for depths that may not be realistic. Also added a unit test for the as_curve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matt
I had some time so I took a look at this. Turns out the problem was with the wavelet. At some point in the past, the input into the wavelet calculation was made in seconds rather than milliseconds but the ricker calculation expected ms. I changed the ricker calculation to accept seconds (which I believe matches the bruges version).
During testing, I noticed a bug on the as_curve function so I fixed that as well with an improvement over the handling of the log output interval. I also made a change in the make_synthetic where the user can add their chosen sonic and density mneonics rather than having to rename them to DT and RHOB (which remain the defaults).
Hope this meets with your approval.
Corey