Banner edit links did not work correctly

[cat-in-136]

Summary

Banner edit links did not work correctly

Description

Clicking the edit link on the banner navigates the edit page /global_banner/1234 opens (where 1234 seems to be :id of the origin page). When updating the banner from here, the POST to /global_banner/1234 is invoked, but the URL does not accept POST, resulting cause a 404 error.

Banner edit page from the Redmine admin page navigates /global_banner/ (without :id number). This issue is not reproduced from the edit page without :id number.

Environment

• Redmine version: 5.0.5
• Installed plugins: confirmed that this issue is reproduced with only this plugin installed.
• Ruby version: 3.1.3-p185
• OS Platform: linux
• Database (MariaDB, MySQL, PostgreSQL) and its version: PostgreSQL, SQLite
• Rails Env

Visual Proof / Screenshot

Go to some issue page. Here is http://example.com/issues/15

Click "Edit" link to navigate to http://example.com/global_banner/15

Click "Apply" button causes 404 Error.

Expected Results

Update banner

Actual Results

404 Not Found

Note that it is caused by routing error. If debug mode, you can see routing error page:

Workaround

There are some workarounds:

• update the banner from Redmine admin page
• modify edit link URL on the banner using view_customize
• modify edit link URL on the banner with source code modification