Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid parameter loss when sort issue_template #61

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Avoid parameter loss when sort issue_template #61

merged 1 commit into from
Mar 20, 2023

Conversation

kumojima
Copy link

refer to #27 (comment)

@nishidayuya nishidayuya requested a review from mk2 March 15, 2023 09:09
mk2
mk2 approved these changes Mar 17, 2023
View reviewed changes
Copy link

@mk2 mk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

nishidayuya
nishidayuya approved these changes Mar 17, 2023
View reviewed changes
Copy link

@nishidayuya nishidayuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@yurie-mizushima yurie-mizushima marked this pull request as ready for review March 20, 2023 02:33
@yurie-mizushima yurie-mizushima merged commit ebca97f into master Mar 20, 2023
@yurie-mizushima yurie-mizushima deleted the fix_valid_params branch March 20, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishidayuya nishidayuya nishidayuya approved these changes

@mk2 mk2 mk2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumojima @nishidayuya @mk2 @yurie-mizushima