Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout crash #28

Closed
steverc opened this issue Sep 21, 2015 · 2 comments
Closed

Timeout crash #28

steverc opened this issue Sep 21, 2015 · 2 comments

Comments

@steverc
Copy link

steverc commented Sep 21, 2015

After 1 hour the tokens expires; the timeout crashes the server.
It looks like the problem is in index.js at line 954:
https://github.com/agmoyano/OpenIDConnect/blob/master/index.js#L954

Probably auth.access and/or auth.refresh do not exist, and that's the reason of the crash...
@agmoyano
Copy link
Owner

Hi, I'll check into it. Would you like to PR?

Thanks

@steverc
Copy link
Author

steverc commented Sep 28, 2015

Hi, I added a PR that avoids crash, but I'm not sure about functionality...
Thanks!

agmoyano added a commit that referenced this issue Sep 28, 2015
@agmoyano
Fixing issue #28. Changed refresh.auth to access.auth in line 950 of …
77923e4 
…index.js
@steverc steverc mentioned this issue Sep 29, 2015
Open
dash- pushed a commit to dash-/OpenIDConnect that referenced this issue Oct 20, 2015
Changed occurrences of auth.access to auth.accessTokens; changed occu…
7f48c60 
…rrences of auth.refresh to auth.refreshTokens; as originally recommended by steverc in issue agmoyano#31 (related also to agmoyano#28 and agmoyano#33)
@dash- dash- mentioned this issue Oct 20, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@steverc @agmoyano