Feat: Remove an avatar #371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was... harder than I thought.
When there's an avatar, just show a remove button. When you click remove, you can upload or generate one.
To achieve that though, because the avatar field was used and it's using a multipart post, I had to be creative. I'm posting a clearAvatar item, which is converted to '' in the db call, which is then passed as $unset.
I didn't want to refactor, so that's the best I could find. otherwise, maybe it would be easier to have a separate "ordinary" POST with the character JSON, and separately upload the image from the client, instead of doing that on the server?
For now that should work fine.