Audio and Video interface updates #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysolanky
reviewed
Jan 16, 2025
libs/agno/agno/models/message.py
Outdated
| _logger("Message contains raw audio data") | ||
| else: | ||
| _logger(f"Audio file added: {self.audio}") | ||
| _logger(f"Audios added: {len(self.audio)}") |
There was a problem hiding this comment.
Can we please revert to Audio Files? Audios does not sound right
ysolanky
reviewed
Jan 16, 2025
| @@ -183,6 +185,50 @@ def format_image_for_message(self, image: ImageInput) -> Optional[Dict[str, Any] | |||
| logger.warning(f"Unknown image type: {type(image)}") | |||
| return None | |||
|
|
|||
| def format_audio_for_message(self, audio: AudioInput) -> Optional[Dict[str, Any]]: | |||
There was a problem hiding this comment.
Why did we remove the functionality for providing a local path for an audio file directly?
There was a problem hiding this comment.
Good call. I added it so it has the same interface as video.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The next round of interface changes for Audio and Video, to make it consistent with Images