feat/realtime #2131
feat/realtime #2131
Conversation
There was a problem hiding this comment.
This is a great start to make it work with our implementation.
I think if we are going to release this, it has to be with either a built-in websocket interface or a guide on how to build a websocket API using the real-time model.
Because live/cli mode is great for testing, but it doesn't translate to production right?
| messages=self.run_response.messages, | ||
| extra_data=self.run_response.extra_data, | ||
| event=event.value, | ||
| # tools=self.run_response.tools, |
| await self.aprint_response(message=message, stream=stream, markdown=markdown, **kwargs) | ||
|
|
||
|
|
||
| async def live(self, exit_on: Optional[List[str]] = None, **kwargs: Any): |
There was a problem hiding this comment.
How is this different from the acli experience?
| @@ -3808,3 +3808,97 @@ def cli_app( | |||
| break | |||
|
|
|||
| self.print_response(message=message, stream=stream, markdown=markdown, **kwargs) | |||
|
|
|||
| async def acli_app( | |||
There was a problem hiding this comment.
If we are doing this it might be worthit to consider the DX here.
- We could consider making CLI / Live a separate class that takes an agent in a constructor, similar to a playground app setup. I kinda feel like it would be more intuitive to use, even though it is more lines of code?
- Alternatively this needs a better name I think.
run_liveandarun_live?
|
|
||
| async def create_connection(self): | ||
| """Create and store a persistent connection.""" | ||
| self.connection = await self.get_async_client().beta.realtime.connect(model=self.id).enter() |
There was a problem hiding this comment.
This can be done in get client right?
|
|
||
|
|
||
| @dataclass | ||
| class OpenAIRealtime(Model): |
There was a problem hiding this comment.
Should we consider making a whole new base_model for realtime models? They kinda work in fundamentally a different way? It could then support a connection and methods like send_message(both text and audio), process_response, etc.
Description
Realtime init
Type of change
Please check the options that are relevant:
Checklist
./scripts/format.shand./scripts/validate.shto ensure code is formatted and linted.Additional Notes
Include any deployment notes, performance implications, security considerations, or other relevant information (e.g., screenshots or logs if applicable).