TooTallNate#66 - fixed empty key

agoldis · Jan 26, 2016 · 421c7f2 · 421c7f2
1 parent 6952057
commit 421c7f2
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/lib/parse.js b/lib/parse.js
@@ -31,6 +31,23 @@ function shouldIgnoreNode (node) {
     || node.nodeType === 4;  // cdata
 }
 
+/**
+ * Check if the node is empty. Some plist file has such node:
+ * <key />
+ * this node shoud be ignored.
+ *
+ * @see https://github.com/TooTallNate/plist.js/issues/66
+ * @param {Element} node
+ * @returns {Boolean}
+ * @api private
+ */
+function isEmptyNode(node){
+  if(!node.childNodes || node.childNodes.length == 0) {
+    return true;
+  } else {
+    return false;
+  }
+}
 
 /**
  * Parses a Plist XML string. Returns an Object.
@@ -118,7 +135,7 @@ function parsePlistXML (node) {
     new_arr = [];
     for (i=0; i < node.childNodes.length; i++) {
       // ignore comment nodes (text)
-      if (!shouldIgnoreNode(node.childNodes[i])) {
+      if (!shouldIgnoreNode(node.childNodes[i]) && !isEmptyNode(node)) {
         new_arr.push( parsePlistXML(node.childNodes[i]));
       }
     }