Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve imports #10

Merged
merged 8 commits into from
Sep 15, 2021
Merged

Improve imports #10

merged 8 commits into from
Sep 15, 2021

Conversation

fcollonval
Copy link
Collaborator

@fcollonval fcollonval commented Sep 14, 2021

Fix some imports and set jupyterlab-markup as dependency

I had to remove the auto disabling core factory. If it is set, the notebook editor is not available any more. I don't know why.

Sounds like a bug in JLab because if I manually set jupyter labextension disable "@jupyterlab/notebook-extension:factory", everything works fine.

@agoose77
Copy link
Owner

Thanks for cleaning these up, also needed to be done.

I'm not sure on the protocol for adding dependencies in the Python package, which is why I left it out until now. My gut instinct is that we should assume if the user is installing one extension via PyPI, they want both via PyPI, so I'm on board with the suggestion.

@agoose77
Copy link
Owner

Let's add an install for jupyterlab too so that we have jlpm. I'd still like to use a PEP517 builder with isolation for the package build stage.

@agoose77
Copy link
Owner

agoose77 commented Sep 15, 2021

LGTM :)

@fcollonval
Copy link
Collaborator Author

Thanks I'm trying it on binder as I still have a doubt about the disabledExtensions setup in package.json. If it works, I'll then merge.

@fcollonval
Copy link
Collaborator Author

I confirm that if disabledExtensions is set, it breaks JupyterLab. So I remove it. I'll merge as the error is unrelated.

@fcollonval fcollonval merged commit 13bdd2d into agoose77:master Sep 15, 2021
@fcollonval fcollonval deleted the fix/imports branch September 15, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants