-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve imports #10
Improve imports #10
Conversation
Thanks for cleaning these up, also needed to be done. I'm not sure on the protocol for adding dependencies in the Python package, which is why I left it out until now. My gut instinct is that we should assume if the user is installing one extension via PyPI, they want both via PyPI, so I'm on board with the suggestion. |
782baf9
to
052dfce
Compare
Let's add an install for |
LGTM :) |
Thanks I'm trying it on binder as I still have a doubt about the |
I confirm that if |
Fix some imports and set
jupyterlab-markup
as dependencyI had to remove the auto disabling core factory. If it is set, the notebook editor is not available any more. I don't know why.
Sounds like a bug in JLab because if I manually set
jupyter labextension disable "@jupyterlab/notebook-extension:factory"
, everything works fine.